security: sanitize user input in temp directory names #411
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Security Issue Addressed
Directory Traversal Risk (Medium) - Previously, user email was used directly in temporary directory names via
os.MkdirTemp("", "taskwarrior-"+email). If the email contained path separators or special characters, it could potentially cause path-related issues.Changes
backend/utils/sanitize.go: New file withSafeTempDirPrefix()functionUpdated files to use
SafeTempDirPrefix:backend/utils/tw/add_task.gobackend/utils/tw/complete_task.gobackend/utils/tw/complete_tasks.gobackend/utils/tw/delete_task.gobackend/utils/tw/delete_tasks.gobackend/utils/tw/edit_task.gobackend/utils/tw/fetch_tasks.gobackend/utils/tw/modify_task.goTest plan
🤖 Generated with Claude Code