Fixed - [Bug] Foundation upgrade broke lay-out

[sanchaymittal]

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

• I have read and understood the contributors guide.
• I have checked that another pull request for this purpose does not exist.
• I have considered, and confirmed that this submission will be valuable to others.
• I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
• I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

• I have never used the project.
• I have used the project briefly.
• I have used the project extensively, but have not contributed previously.
• I am an active contributor to the project.

---

Fixed the broken layout, working smoothly in both desktop and mobile layout.

[codecov]

Codecov Report

Merging #189 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #189   +/-   ##
======================================
  Coverage    1.32%   1.32%           
======================================
  Files          34      34           
  Lines        2789    2789           
  Branches      329     329           
======================================
  Hits           37      37           
  Misses       2751    2751           
  Partials        1       1

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0e9977...8f06613. Read the comment docs.

[sanchaymittal]

pre fix screenshots

post fix screenshots

[satyammittal]

@sanchaymittal Please update your branch with master.

[canihavesomecoffee]

If you just want to fix the footer, why did you put it in here? Now this will apply to all those elements as well. That makes no sense.

[sanchaymittal]

I can use a separate id or class for this but the changes now doesn't affect others because of their orientation.

[canihavesomecoffee]

Still, I'd like to see it in a separate section.

[sanchaymittal]

@canihavesomecoffee but it's better this way as it aligned with symmetry with others

[canihavesomecoffee]

Why is this padding necessary?

[sanchaymittal]

Padding is required at the end of the page for mobile and other scroll screens.

[sanchaymittal]

@canihavesomecoffee ??

[satyammittal]

@sanchaymittal Please check the fix on chrome, It looks like

and One more change, don't add unnecessary tab /+ spaces like you added in 340 line.

[sanchaymittal]

In Chrome, I think it's perfectly ok


and i haven't noticed the extra tab
Thanks for that 🙂

[satyammittal]

@sanchaymittal Great, I updated my google chrome to 64.0, Yeah it looks fine in both windows and linux.

[canihavesomecoffee]

So any menu element or any other will be fixed to the bottom? I'd still like to see a separate change for footer elements only.