[Fix] Convert Markdown To HTML Email Body#266
[Fix] Convert Markdown To HTML Email Body#266canihavesomecoffee merged 7 commits intoCCExtractor:masterfrom
Conversation
|
Hello @thealphadollar, Thank you for updating the PR! Great work! I discovered no PEP8 issues in this Pull Request. 🥇 Comment last updated at 2019-05-23 06:52:24 UTC |
3547ec3 to
7a2933f
Compare
|
cc/ @canihavesomecoffee @satyammittal Please approve :) |
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
==========================================
+ Coverage 65.06% 65.14% +0.07%
==========================================
Files 34 34
Lines 3051 3058 +7
Branches 375 375
==========================================
+ Hits 1985 1992 +7
Misses 960 960
Partials 106 106
Continue to review full report at Codecov.
|
|
before/after pics? |
I had added them but were not properly uploaded; rectified now. Please leave your views and suggestions 😄 |
canihavesomecoffee
left a comment
There was a problem hiding this comment.
Remind me this evening to merge & install the new dependency on the live version :)
canihavesomecoffee
left a comment
There was a problem hiding this comment.
Could you add a unittest that tests the new method you added? :)
Will do :) |
|
@canihavesomecoffee Test has been added. |
59bfec3 to
957ff6b
Compare
Remove by-mistake commited file.
a696c48 to
4b77241
Compare
Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
In reference to issue #264 , the PR uses the HTML method of mailgun API to send the issue body (originally in markdown) by first converting it into HTML using markdown2 along with extras to add more features and convert the task list.
Below is an example of how the emails would look after the PR is merged.
OLD
NEW
The unit-test for inform_mailing_list function has been updated accordingly.
fixes #264