Skip to content

[IMPROVEMENT] update PR comment template #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
canihavesomecoffee merged 1 commit into from
Jul 7, 2025
Merged

[IMPROVEMENT] update PR comment template #931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions templates/ci/pr_comment.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<b>CCExtractor CI platform</b> finished running the test files on <b>{{platform}}</b>. Below is a summary of the test results{% if comment_info.last_test_master %}, when compared to <a href="{{ url_for('test.by_id', test_id=comment_info.last_test_master.id, _external=True) }}">test for commit {{ comment_info.last_test_master.commit[:7] }}...</a>{% endif %}:
<details>
<summary><b>CCExtractor CI platform</b> finished running the test files on <b>{{platform}}</b>. Below is a summary of the test results{% if comment_info.last_test_master %}, when compared to <a href="{{ url_for('test.by_id', test_id=comment_info.last_test_master.id, _external=True) }}">test for commit {{ comment_info.last_test_master.commit[:7] }}...</a>{% endif %}:</summary>
<table>
<thead>
<td> Report Name </td>
Expand All @@ -18,16 +19,12 @@
{% endfor %}
</table>
{% if comment_info.extra_failed_tests | length %}
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:
<ul>
{% for test in comment_info.extra_failed_tests %}
<li> ccextractor {{ test.command }} <a href="{{ url_for('sample.sample_by_id', sample_id=test.sample.id, _external=True) }}">{{ test.sample.sha[:10] }}...</a></li>
{% endfor %}
</ul>
{% else %}
All tests passing on the master branch were passed completely.
{% endif %}
{% if comment_info.common_failed_tests | length %}
NOTE: The following tests have been failing on the master branch as well as the PR:
Expand All @@ -46,4 +43,12 @@ Congratulations: Merging this PR would fix the following tests:
</ul>
{% endif %}
<br>
</details>

{% if comment_info.extra_failed_tests | length %}
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).
{% else %}
All tests passing on the master branch were passed completely.
{% endif %}

Check the <a href="{{ url_for('test.by_id', test_id=test_id, _external=True) }}">result</a> page for more info.
Loading