Skip to content

Remove conditional MDAnalysis install logic #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
harryswift01 merged 1 commit into from
Nov 17, 2025
Merged

Remove conditional MDAnalysis install logic #184

harryswift01 merged 1 commit into from
Nov 17, 2025

Conversation

@harryswift01
Copy link
Contributor

@harryswift01 harryswift01 commented Nov 17, 2025

Summary

Removes unused MDAnalysis version check from the compatibility workflow now that the version is pinned.

Changes

Simplify MDAnalysis installation

  • Removed conditional logic for handling the latest version.
  • MDAnalysis is now always installed using the pinned version.

Impact

  • Reduces workflow complexity.
  • Prevents unnecessary branching and potential cross-platform issues.

@harryswift01 harryswift01 self-assigned this Nov 17, 2025
@harryswift01 harryswift01 added the bug Something isn't working label Nov 17, 2025
@harryswift01 harryswift01 requested a review from jimboid November 17, 2025 11:55
jimboid
jimboid approved these changes Nov 17, 2025
View reviewed changes
Copy link
Member

@jimboid jimboid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@harryswift01 harryswift01 merged commit b0be562 into main Nov 17, 2025
14 checks passed
@harryswift01 harryswift01 deleted the 181-use-latest-for-mdanalysis branch November 17, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimboid jimboid jimboid approved these changes

Assignees

@harryswift01 harryswift01

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@harryswift01 @jimboid