Conversation
|
@remram44 Can you please make sure everything is OK? @cameronsmith1 , @doutriaux1 can you please try this branch? |
There was a problem hiding this comment.
What is this second loop for?
There was a problem hiding this comment.
Second loop is to generate the popup errors of dependency if there are any
in the final list..
On Friday, March 6, 2015, Remi Rampin notifications@github.com wrote:
In vistrails/gui/uvcdat/definedVariableWidget.py
#22 (comment):for v in self.getSelectedDefinedVariables():
self.deleteVariable(v.id)self.deleteVariable(v.id,count)What is this second loop for?
—
Reply to this email directly or view it on GitHub
https://github.com/UV-CDAT/VisTrails/pull/22/files#r25926962.
There was a problem hiding this comment.
Can you replace "count" "1" and "2" with a readable parameter?
There was a problem hiding this comment.
OK I will.
On Friday, March 6, 2015, Remi Rampin notifications@github.com wrote:
In vistrails/gui/uvcdat/definedVariableWidget.py
#22 (comment):for v in self.getSelectedDefinedVariables():
self.deleteVariable(v.id)self.deleteVariable(v.id,count)Can you replace "count" "1" and "2" with a readable parameter?
—
Reply to this email directly or view it on GitHub
https://github.com/UV-CDAT/VisTrails/pull/22/files#r25954614.
313714c to
23a6a61
Compare
23a6a61 to
a08c813
Compare
|
I had to rewrite the whole thing but here we go. |
Fixes deleting inter-dependent variables
Fixes CDAT/cdat#897