Skip to content

Variables deletion reloaded#22

Merged
remram44 merged 3 commits intouvcdat-masterfrom
variables_deletion_reloaded
Mar 16, 2015
Merged

Variables deletion reloaded#22
remram44 merged 3 commits intouvcdat-masterfrom
variables_deletion_reloaded

Conversation

@hgohil2805
Copy link
Copy Markdown

  • Works for various levels of dependencies between variables.
  • removed the trash all method as it's not being used anywhere

Fixes CDAT/cdat#897

@hgohil2805
Copy link
Copy Markdown
Author

@remram44 Can you please make sure everything is OK?

@cameronsmith1 , @doutriaux1 can you please try this branch?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this second loop for?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second loop is to generate the popup errors of dependency if there are any
in the final list..

On Friday, March 6, 2015, Remi Rampin notifications@github.com wrote:

In vistrails/gui/uvcdat/definedVariableWidget.py
#22 (comment):

     for v in self.getSelectedDefinedVariables():
  •        self.deleteVariable(v.id)
    
  •        self.deleteVariable(v.id,count)
    

What is this second loop for?


Reply to this email directly or view it on GitHub
https://github.com/UV-CDAT/VisTrails/pull/22/files#r25926962.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you replace "count" "1" and "2" with a readable parameter?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I will.

On Friday, March 6, 2015, Remi Rampin notifications@github.com wrote:

In vistrails/gui/uvcdat/definedVariableWidget.py
#22 (comment):

     for v in self.getSelectedDefinedVariables():
  •        self.deleteVariable(v.id)
    
  •        self.deleteVariable(v.id,count)
    

Can you replace "count" "1" and "2" with a readable parameter?


Reply to this email directly or view it on GitHub
https://github.com/UV-CDAT/VisTrails/pull/22/files#r25954614.

@remram44 remram44 force-pushed the variables_deletion_reloaded branch from 313714c to 23a6a61 Compare March 16, 2015 14:12
@remram44 remram44 force-pushed the variables_deletion_reloaded branch from 23a6a61 to a08c813 Compare March 16, 2015 14:17
@remram44
Copy link
Copy Markdown
Contributor

I had to rewrite the whole thing but here we go.

remram44 added a commit that referenced this pull request Mar 16, 2015
Fixes deleting inter-dependent variables
@remram44 remram44 merged commit 2a04fba into uvcdat-master Mar 16, 2015
@doutriaux1 doutriaux1 deleted the variables_deletion_reloaded branch April 9, 2015 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deleting all variables doesn't work if one variable is derived from another (in GUI).

2 participants