Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Out of source detection is broken #713

Closed
remram44 opened this issue Sep 26, 2014 · 5 comments
Closed

Out of source detection is broken #713

remram44 opened this issue Sep 26, 2014 · 5 comments
Assignees
@aashish24
Labels
Bug Build
Milestone
2.2

Comments

@remram44
Copy link
Contributor

The BUILDINSOURCE check in the main CMakeLists.txt is broken; building in /home/vagrant/build-uvcdat when the source is in /vagrant makes it think I'm building in the source. Very annoying, since it always affects Vagrant.
@aashish24 aashish24 added this to the 2.1 milestone Sep 29, 2014
@aashish24
Copy link
Contributor

@dlonie Can you look at this issue please. Probably a one line fix (but we have to be careful about the regex)

@aashish24 aashish24 assigned alliepiper and unassigned aashish24 Oct 3, 2014
@alliepiper alliepiper mentioned this issue Oct 3, 2014
Merged
@alliepiper
Copy link
Contributor

Should be fixed now. @remram44, can you let us know if this is working for you when you get a chance to try it out?

@remram44
Copy link
Contributor Author

remram44 commented Oct 6, 2014

Yes the patch was enough for my setup.

@remram44 remram44 closed this as completed Oct 6, 2014
@remram44 remram44 reopened this Nov 17, 2014
@remram44 remram44 mentioned this issue Nov 18, 2014
Closed
@remram44 remram44 assigned aashish24 and unassigned alliepiper Nov 18, 2014
@doutriaux1 doutriaux1 modified the milestones: 2.1, 2.2 Feb 2, 2015
@doutriaux1
Copy link
Contributor

@remram44 is that fixed now?

@remram44
Copy link
Contributor Author

Was fixed by #973

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aashish24 aashish24

Labels
Bug Build
Projects
None yet
Milestone
2.2
Development

Successfully merging a pull request may close this issue.

Fixes BUILDINSOURCE detection remram44/uvcdat
4 participants
@alliepiper @aashish24 @remram44 @doutriaux1