Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize vtk #1038

Merged
merged 1 commit into from Feb 21, 2015
Merged

Optimize vtk #1038

merged 1 commit into from Feb 21, 2015

Conversation

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Feb 13, 2015

@aashish24 @dlonie @chaosphere2112 @williams13

This is the merge for animations

I still need input to add tests for animations, not sure how to go at it, but just added option to "preserve" png files at exit might be the way to go.

Lots of changes, so it's a big job to review.

@@ -74,7 +74,7 @@
import vcs.manageElements

class SIGNAL(object):

Copy link
Contributor

@allisonvacanti allisonvacanti Feb 17, 2015

FWIW, it's generally a bad idea to mix large whitespace-only (or other maintenance-oriented) changes with actual code changes.

It makes it more difficult for reviewers to find the actual changes that need reviewing, and leads to odd VCS histories (for instance, changing non-VTK related files in a topic that is focused on cleaning up VTK usage).

Copy link
Contributor Author

@doutriaux1 doutriaux1 Feb 18, 2015

i think these are due to our pre-commit that refuses to have any white space at the end of lines.... VERY annoying, so I believe I ran some sed on the files to get rid of all of them massively

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Feb 18, 2015

@dlonie addressed your comments. Thanks!

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Feb 18, 2015

@doutriaux1 there are quite a few of issues we found with this code. Let me schedule a tcon with you and @dlonie on Friday to discuss these.

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Feb 18, 2015

@aashish24 @dlonie friday is code freeze, why wait so long?

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Feb 18, 2015

@dlonie @aashish24 what are the issues left, please post here or email me, I would rather not have to wait until the last minute to fix this.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Feb 19, 2015

@doutriaux1 this branch has lot of issues. We shouldn't merge this as it is. Let's talk sometime today.

missingMapper = None
if vtkobjects.has_key("vtk_backend_contours"):
for c in vtkobjects["vtk_backend_contours"]:
c.Update()
Copy link
Contributor

@aashish24 aashish24 Feb 19, 2015

no need to call actors manually..

@chaosphere2112
Copy link
Contributor

@chaosphere2112 chaosphere2112 commented Feb 19, 2015

@aashish24 @doutriaux1 Can I sit in on that call? I'm dependent on this branch for the VCS2D interactivity stuff I'm working on– the actors that Charles exposes are used to skip all of the previously used canvas.update() calls.

def draw_frame(self):
png_name=os.path.join(os.environ["HOME"],".uvcdat",self._unique_prefix,"anim_%i.png" % self.frame_num)
if os.path.exists(png_name) and len(self.animation_files)==self.number_of_frames():
## Ok we have the pngs and we need to zoom, need to use png
Copy link
Contributor

@chaosphere2112 chaosphere2112 Feb 19, 2015

Can we get an option to require that we don't use PNGs? This will help a lot with scrubbing the animation from the VCS2D interactive code.

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Feb 19, 2015

@aashish24 trying to reach you but can't get through either work or cell phone

@allisonvacanti
Copy link
Contributor

@allisonvacanti allisonvacanti commented Feb 20, 2015

Two failures, but I believe these were fixed in a recent patch (IIRC the filenames were incorrect).

https://www.cdash.org/viewTest.php?onlyfailed&buildid=3702821

LGTM -- @doutriaux1 let me know if those failures are ok and I'll merge.

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Feb 20, 2015

@dlonie @aashish24 fix for these tests is already in another PR see commit 18709de

@chaosphere2112
Copy link
Contributor

@chaosphere2112 chaosphere2112 commented Feb 21, 2015

I'm gonna go ahead and merge this

@chaosphere2112 chaosphere2112 merged commit 84bdabb into CDAT:master Feb 21, 2015
1 check passed
chaosphere2112 added a commit that referenced this issue Feb 21, 2015
@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Feb 21, 2015

all right little beetle! I like that move! Do you feel the power rush?

@chaosphere2112
Copy link
Contributor

@chaosphere2112 chaosphere2112 commented Feb 21, 2015

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Feb 21, 2015

apparently in english it's not "little beetle" but "grasshopper"
kung-fu_tv-master_po-young_grasshopper

@chaosphere2112
Copy link
Contributor

@chaosphere2112 chaosphere2112 commented Feb 21, 2015

But at least je n'ai pas un chat dans la gorge!

(High school french left me with a number of weird colloquialisms ingrained into my mind)

@doutriaux1 doutriaux1 deleted the optimize_vtk branch Mar 4, 2015
@coveralls
Copy link

@coveralls coveralls commented Sep 23, 2016

Coverage Status

Changes Unknown when pulling 84bdabb on doutriaux1:optimize_vtk into * on UV-CDAT:master*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants