Optimize vtk #1038
Optimize vtk #1038
Conversation
| @@ -74,7 +74,7 @@ | |||
| import vcs.manageElements | |||
|
|
|||
| class SIGNAL(object): | |||
|
|
|||
There was a problem hiding this comment.
FWIW, it's generally a bad idea to mix large whitespace-only (or other maintenance-oriented) changes with actual code changes.
It makes it more difficult for reviewers to find the actual changes that need reviewing, and leads to odd VCS histories (for instance, changing non-VTK related files in a topic that is focused on cleaning up VTK usage).
There was a problem hiding this comment.
i think these are due to our pre-commit that refuses to have any white space at the end of lines.... VERY annoying, so I believe I ran some sed on the files to get rid of all of them massively
|
@dlonie addressed your comments. Thanks! |
|
@doutriaux1 there are quite a few of issues we found with this code. Let me schedule a tcon with you and @dlonie on Friday to discuss these. |
|
@aashish24 @dlonie friday is code freeze, why wait so long? |
|
@dlonie @aashish24 what are the issues left, please post here or email me, I would rather not have to wait until the last minute to fix this. |
|
@doutriaux1 this branch has lot of issues. We shouldn't merge this as it is. Let's talk sometime today. |
| missingMapper = None | ||
| if vtkobjects.has_key("vtk_backend_contours"): | ||
| for c in vtkobjects["vtk_backend_contours"]: | ||
| c.Update() |
There was a problem hiding this comment.
no need to call actors manually..
|
@aashish24 @doutriaux1 Can I sit in on that call? I'm dependent on this branch for the VCS2D interactivity stuff I'm working on– the actors that Charles exposes are used to skip all of the previously used canvas.update() calls. |
| def draw_frame(self): | ||
| png_name=os.path.join(os.environ["HOME"],".uvcdat",self._unique_prefix,"anim_%i.png" % self.frame_num) | ||
| if os.path.exists(png_name) and len(self.animation_files)==self.number_of_frames(): | ||
| ## Ok we have the pngs and we need to zoom, need to use png |
There was a problem hiding this comment.
Can we get an option to require that we don't use PNGs? This will help a lot with scrubbing the animation from the VCS2D interactive code.
|
@aashish24 trying to reach you but can't get through either work or cell phone |
draw_frame specify frame #
|
Two failures, but I believe these were fixed in a recent patch (IIRC the filenames were incorrect). https://www.cdash.org/viewTest.php?onlyfailed&buildid=3702821 LGTM -- @doutriaux1 let me know if those failures are ok and I'll merge. |
|
@dlonie @aashish24 fix for these tests is already in another PR see commit 18709de |
|
I'm gonna go ahead and merge this |
|
all right little beetle! I like that move! Do you feel the power rush? |
|
|
|
apparently in english it's not "little beetle" but "grasshopper" |
|
But at least je n'ai pas un chat dans la gorge! (High school french left me with a number of weird colloquialisms ingrained into my mind) |
|
Changes Unknown when pulling 84bdabb on doutriaux1:optimize_vtk into * on UV-CDAT:master*. |
@aashish24 @dlonie @chaosphere2112 @williams13
This is the merge for animations
I still need input to add tests for animations, not sure how to go at it, but just added option to "preserve" png files at exit might be the way to go.
Lots of changes, so it's a big job to review.