Merged
Conversation
Contributor
There was a problem hiding this comment.
FWIW, it's generally a bad idea to mix large whitespace-only (or other maintenance-oriented) changes with actual code changes.
It makes it more difficult for reviewers to find the actual changes that need reviewing, and leads to odd VCS histories (for instance, changing non-VTK related files in a topic that is focused on cleaning up VTK usage).
Contributor
Author
There was a problem hiding this comment.
i think these are due to our pre-commit that refuses to have any white space at the end of lines.... VERY annoying, so I believe I ran some sed on the files to get rid of all of them massively
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@aashish24 @dlonie @chaosphere2112 @williams13
This is the merge for animations
I still need input to add tests for animations, not sure how to go at it, but just added option to "preserve" png files at exit might be the way to go.
Lots of changes, so it's a big job to review.