Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake fixes #1062

Merged
merged 10 commits into from Feb 23, 2015
Merged

Cmake fixes #1062

merged 10 commits into from Feb 23, 2015

Conversation

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Feb 21, 2015

Fixed #825 and various other minor issues

@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Feb 21, 2015

@doutriaux1 @dlonie please approve.

endif()
else()
message(WARNING "Unable to extract remote for '${_branch}' using default VisTrails branch")
Copy link
Contributor

@doutriaux1 doutriaux1 Feb 21, 2015

Why remove that one it was kind of nice to know it couldn't get the desired branch

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Feb 23, 2015

@aashish24 ok work for me so I'm going to merge. I don't see the options for taking ParaView out unless specified -DCDAT_BUILD_PARAVIEW=ON, so that we can do a -DCDAT_BUILD_MODE=ALL that does not build ParaView

doutriaux1 added a commit that referenced this issue Feb 23, 2015
@doutriaux1 doutriaux1 merged commit 151cd8b into master Feb 23, 2015
2 checks passed
@doutriaux1 doutriaux1 deleted the cmake_fixes branch Feb 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants