Workaround for #1093 #1135
Merged
Workaround for #1093 #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hum... on ubunutu after resizing it gets all weirded out and clicking show angle doesn't do anything |
|
@doutriaux1 The resizing issues should be addressed in #1113; do you want to hold off on merging this till then, or can we put it in now? The issues weren't really related to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates the scenario that leads to the segfault in #1093 by replacing the font menu with a font button. Instead of getting previews of all of the fonts, you get a single button that cycles through the different fonts. Less good, but less crash-prone.
I extracted font selection out into a separate class so when we actually fix the root of #1093 it should be pretty easy to bring back the more complicated but more user-friendly UI. We can either leave #1093 open (and move to 2.3) or closed (and create an enhancement request to add a menu for fonts); I'd lean towards the latter.