New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for #1093 #1135

Merged
merged 1 commit into from Mar 24, 2015

Conversation

Projects
None yet
2 participants
@chaosphere2112
Contributor

chaosphere2112 commented Mar 9, 2015

Eliminates the scenario that leads to the segfault in #1093 by replacing the font menu with a font button. Instead of getting previews of all of the fonts, you get a single button that cycles through the different fonts. Less good, but less crash-prone.

I extracted font selection out into a separate class so when we actually fix the root of #1093 it should be pretty easy to bring back the more complicated but more user-friendly UI. We can either leave #1093 open (and move to 2.3) or closed (and create an enhancement request to add a menu for fonts); I'd lean towards the latter.

Sam Fries
@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented Mar 9, 2015

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Mar 9, 2015

hum... on ubunutu after resizing it gets all weirded out and clicking show angle doesn't do anything
screenshot from 2015-03-09 13 35 16

@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented Mar 11, 2015

@doutriaux1 The resizing issues should be addressed in #1113; do you want to hold off on merging this till then, or can we put it in now? The issues weren't really related to this PR.

doutriaux1 added a commit that referenced this pull request Mar 24, 2015

@doutriaux1 doutriaux1 merged commit e0b80a1 into CDAT:master Mar 24, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment