New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D support for vcs.update #1184

Merged
merged 3 commits into from Apr 2, 2015

Conversation

Projects
None yet
4 participants
@chaosphere2112
Contributor

chaosphere2112 commented Apr 1, 2015

@ThomasMaxwell I was trying to cook up a camera manipulation demo for @jypeter when I discovered that updating the camera on a 3D graphics method wasn't doing much, even when I replotted / called canvas.update(). I made a few minimal tweaks to better support those operations. If you can take a look at what I did and make sure it wasn't anything dumb, that'd be awesome.

@ThomasMaxwell

This comment has been minimized.

Contributor

ThomasMaxwell commented Apr 1, 2015

Sam,
As long as the ctests pass this should be fine. Thanks.

— Tom

From: Sam Fries <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Wednesday, April 1, 2015 at 2:40 PM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Cc: "Maxwell, Thomas P. (GSFC-606.2)[SCIENCE APPLICATIONS INTL CORP]" <thomas.maxwell@nasa.govmailto:thomas.maxwell@nasa.gov>
Subject: [uvcdat] 3D support for vcs.update (#1184)

@ThomasMaxwellhttps://github.com/ThomasMaxwell I was trying to cook up a camera manipulation demo for @jypeterhttps://github.com/jypeter when I discovered that updating the camera on a 3D graphics method wasn't doing much, even when I replotted / called canvas.update(). I made a few minimal tweaks to better support those operations. If you can take a look at what I did and make sure it wasn't anything dumb, that'd be awesome.


You can view, comment on, or merge this pull request online at:

#1184

Commit Summary

  • Made camera updates propagate when replotting a GM in 3d mode
  • Merge branch 'master' into gm_update_3d
  • Made vcs.update() work on 3D Plots

File Changes

  • M Packages/DV3D/Application.pyhttps://github.com//pull/1184/files#diff-0 (1)
  • M Packages/DV3D/PointCloudViewer.pyhttps://github.com//pull/1184/files#diff-1 (2)
  • M Packages/DV3D/StructuredGridPlot.pyhttps://github.com//pull/1184/files#diff-2 (2)
  • M Packages/vcs/Lib/VTKPlots.pyhttps://github.com//pull/1184/files#diff-3 (22)

Patch Links:


Reply to this email directly or view it on GitHubhttps://github.com//pull/1184.

@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented Apr 1, 2015

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Apr 1, 2015

Sure.. I will run the test and if all works will merge it.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Apr 2, 2015

LGTM 👍

aashish24 added a commit that referenced this pull request Apr 2, 2015

@aashish24 aashish24 merged commit 253f4fd into CDAT:master Apr 2, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@jypeter

This comment has been minimized.

jypeter commented Apr 2, 2015

Thanks Sam et al!
I'm still experimenting with DV3D and I have a few issues to submit before I forget about them. I have only completed #1187 so far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment