New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export svg #2058

Merged
merged 2 commits into from Jul 14, 2016

Conversation

Projects
None yet
3 participants
@aashish24
Contributor

aashish24 commented Jul 13, 2016

No description provided.

@aashish24 aashish24 force-pushed the fix_export_svg branch from c1303ee to 8991302 Jul 13, 2016

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Jul 13, 2016

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Jul 13, 2016

@sankhesh @doutriaux1 please review.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jul 13, 2016

Awesome! thanks @aashish24 will take a look as soon as possible!

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Jul 13, 2016

Do: test

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Jul 13, 2016

LGTM 👍

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jul 14, 2016

@aashish24 @sankhesh I'm about to test this, but I doubt it's going to change anything since my test was a regular isofill no hatch or pattern.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jul 14, 2016

@aashish24 @sankhesh ok I just produced an ungroupable svg on my mac with this branch. I'm going to try it on a Linux system and see if it fixes the svgs for metadiags. Thanks

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jul 14, 2016

@aashish24 @sankhesh with that branch I can ungroup svgs for both boxfill and isofill but not with master. I'm not really sure what's the diff... But hey I'm so happy!

@doutriaux1 doutriaux1 merged commit 24709c5 into master Jul 14, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@doutriaux1 doutriaux1 deleted the fix_export_svg branch Jul 14, 2016

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Jul 14, 2016

great! thanks for the update @doutriaux1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment