Skip to content

851 preserve labels#880

Merged
doutriaux1 merged 6 commits intomasterfrom
851-preserve-labels
Nov 10, 2014
Merged

851 preserve labels#880
doutriaux1 merged 6 commits intomasterfrom
851-preserve-labels

Conversation

@alliepiper
Copy link
Copy Markdown
Contributor

@aashish24 @doutriaux1 Here's the new patch for the large-value contouring issue. I added a regression test for the isofill issue, and rebased it on your issue_851 branch.

The new baseline is in CDAT/uvcdat-testdata#7.

Ref #851

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure about this @dlonie don't we use this option for some tests?

@doutriaux1
Copy link
Copy Markdown
Contributor

@dlonie

doutriaux1@omar:[vcs]:[851-preserve-labels]:[22026]> git diff origin/master -- ../../testing/vcs/test_boxfill_lev1_lev2.py 
diff --git a/testing/vcs/test_boxfill_lev1_lev2.py b/testing/vcs/test_boxfill_lev1_lev2.py
index 4ef02f3..1a6335f 100644
--- a/testing/vcs/test_boxfill_lev1_lev2.py
+++ b/testing/vcs/test_boxfill_lev1_lev2.py
@@ -7,8 +7,8 @@ x=vcs.init()
 f=cdms2.open(sys.prefix+"/sample_data/clt.nc")
 s=f("clt",slice(0,1),squeeze=1)
 b=x.createboxfill()
-b.level_1=.5
-b.level_2=14.5
+b.level_1=20
+b.level_2=80
 x.plot(s,b,bg=1)

 fnm= "test_boxfill_lev1_lev2.png"

why doesn't that file appear in diffs on github?

@doutriaux1
Copy link
Copy Markdown
Contributor

got it, master changed since hence the issues in images diff.... Will update the image push side of things too and rerun ctest.

@doutriaux1
Copy link
Copy Markdown
Contributor

ok test pass after merging master back in. merging

doutriaux1 added a commit that referenced this pull request Nov 10, 2014
@doutriaux1 doutriaux1 merged commit eeff4dc into master Nov 10, 2014
@doutriaux1 doutriaux1 deleted the 851-preserve-labels branch November 18, 2014 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants