-
Notifications
You must be signed in to change notification settings - Fork 65
Issue 691 interact mac broken #905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f67a2b4
put changes back in
doutriaux1 b2c8001
merge master in this
doutriaux1 3b08950
added AnyEvent to see what is happening (not much on mac)
doutriaux1 67998e7
ok this works, needs clean up
doutriaux1 2dc0947
ok not quite there... no left click segfaults
doutriaux1 72dcdc9
ok works on Mac
doutriaux1 6c10ec3
Merge branch 'master' into issue_691_interact_mac_broken
doutriaux1 07f06a7
rendering the clickrenderer seg fault on mac if clicked before and re…
doutriaux1 5df8c14
works on Linux now
doutriaux1 fd3f8ec
@dlonie suggested changes
doutriaux1 e5bdefa
ok got all (?) of @dlonie things
doutriaux1 11fde7d
removed a var that I created while trying some other method. Not needed
doutriaux1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line isn't needed, it's the same instruction as the line before it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping!