New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an option to enable vtkweb #987

Merged
merged 2 commits into from Feb 2, 2015

Conversation

Projects
None yet
4 participants
@jbeezley
Contributor

jbeezley commented Jan 28, 2015

It defaults to off so nothing should blow up.

@@ -73,6 +73,12 @@ if(CDAT_BUILD_OFFSCREEN)
)
endif()

if(CDAT_BUILD_VTKWEB)

This comment has been minimized.

@aashish24

aashish24 Jan 29, 2015

Contributor

How about CDAT_ENABLE_WEB? Or CDAT_BUILD_WEB?

This comment has been minimized.

@jbeezley

jbeezley Jan 29, 2015

Contributor

CDAT_BUILD_* is consistent with the other options. To me, VTKWEB is more explicit unless there is something else that WEB will enable, but I don't have a strong opinion.

This comment has been minimized.

@doutriaux1

doutriaux1 Jan 29, 2015

Member

I like that: CDAT_BUILD_VTKWEB

This comment has been minimized.

@aashish24

aashish24 Jan 29, 2015

Contributor

@doutriaux1 we don't want to expose vtkweb. Web option in the future will enable more than just vtkWeb.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Feb 2, 2015

LGTM 👍

aashish24 added a commit that referenced this pull request Feb 2, 2015

Merge pull request #987 from UV-CDAT/vtkweb-option
Create an option to enable vtkweb

@aashish24 aashish24 merged commit 3bf31ca into master Feb 2, 2015

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details

@aashish24 aashish24 deleted the vtkweb-option branch Feb 2, 2015

@coveralls

This comment has been minimized.

coveralls commented Aug 26, 2016

Coverage Status

Changes Unknown when pulling f0714ee on vtkweb-option into * on master*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment