Compute BB of a projected dataset from all points.#410
Compute BB of a projected dataset from all points.#410danlipsa wants to merge 2 commits intoCDAT:masterfrom
Conversation
|
@doutriaux1 @scottwittenburg Please review. |
scottwittenburg
left a comment
scottwittenburg
left a comment
There was a problem hiding this comment.
Looks good to me if it's passing all the tests.
|
@doutriaux1 Do you know what is going on with coveralls test failure? This is why the first CircleCI is failing. |
|
@danlipsa don't worry about coverage, but could please add a test for this, so we can catch if it breaks again. Thanks. |
|
@doutriaux1 I added a test for this. With master, this test gets the small globe we've seen in the animation example. |
|
@doutriaux1 Do you need to merge uvdat-testdata before the tests pass? I added a branch with the same name but it seems that it is not enough. The test fails because it cannot find the baseline. |
|
Oh, I think data it needs to be a branch to the origin it cannot be a branch on my fork. I'll try that. |
The border in Cartesian space may no corespond to the border in the projected space.
danlipsa
force-pushed
the
projected_isofill_bounds
branch
from
3ab7a3a to
7f302db
Compare
|
Try a a branch of origin in |
4 participants
The border in Cartesian space may no corespond to the border in
the projected space.
Baselines in
CDAT/uvcdat-testdata#212