Skip to content

pass conda_build_env=base for 'make conda-build' and 'make conda-rerender' in circleci/config.yml#448

Merged
muryanto1 merged 1 commit intomasterfrom
fix_conda_build_env
Jul 17, 2020
Merged

pass conda_build_env=base for 'make conda-build' and 'make conda-rerender' in circleci/config.yml#448
muryanto1 merged 1 commit intomasterfrom
fix_conda_build_env

Conversation

@muryanto1
Copy link
Copy Markdown
Member

@muryanto1 muryanto1 commented Jul 17, 2020

  • set conda_build_env and conda_test_env to a default value in Makefile if it is not passed in.
  • pass in 'conda_build_env=base' when doing 'make conda-rerender' and 'make conda-build' in .circleci/config.yml

@muryanto1 muryanto1 requested review from downiec and jasonb5 July 17, 2020 20:39
jasonb5
jasonb5 approved these changes Jul 17, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@jasonb5 jasonb5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muryanto1 muryanto1 merged commit 6e5f054 into master Jul 17, 2020
@muryanto1 muryanto1 deleted the fix_conda_build_env branch July 20, 2020 21:43
@downiec downiec modified the milestones: 8.2, 8.2.1 Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonb5 jasonb5 jasonb5 approved these changes

@downiec downiec Awaiting requested review from downiec

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

8.2.1

Development

Successfully merging this pull request may close these issues.

4 participants

@muryanto1 @jasonb5 @downiec @LinaMuryanto