Skip to content

Rr 123 fix upload#127

Merged
ryanraaschCDC merged 6 commits intomainfrom
rr-123-fix-upload
Mar 6, 2026
Merged

Rr 123 fix upload#127
ryanraaschCDC merged 6 commits intomainfrom
rr-123-fix-upload

Conversation

@ryanraaschCDC
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the “large upload” confirmation prompt in upload_files_in_folder to base the file count on the post-filtered upload list (and changes the threshold), improving accuracy of the confirmation step before uploading to Azure Blob Storage.

Changes:

  • Moves the “confirm large upload” prompt to occur after extension/pattern filtering so the count matches what will actually be uploaded.
  • Changes the confirmation threshold from > 50 files to > 25 files.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cfa/cloudops/blob_helpers.py
Comment thread cfa/cloudops/blob_helpers.py Outdated
Comment thread cfa/cloudops/blob_helpers.py Outdated
ryanraaschCDC and others added 2 commits March 4, 2026 16:22
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ryanraaschCDC ryanraaschCDC self-assigned this Mar 4, 2026
@xop5 xop5 self-requested a review March 6, 2026 18:28
@ryanraaschCDC ryanraaschCDC merged commit 5e6ee14 into main Mar 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[blob_helpers.py](upload_files_in_folder) Asked to confirm file upload count which is incorrect as exclusion patterns are not taken into account.

4 participants