Skip to content

chore: turn off profiling by default#842

Merged
cdc-as81 merged 2 commits intomainfrom
cdc-as81-turn-off-profiling-by-default
Apr 9, 2026
Merged

chore: turn off profiling by default#842
cdc-as81 merged 2 commits intomainfrom
cdc-as81-turn-off-profiling-by-default

Conversation

@cdc-as81
Copy link
Copy Markdown
Collaborator

@cdc-as81 cdc-as81 commented Apr 7, 2026

No description provided.

github-actions Bot added a commit that referenced this pull request Apr 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 7, 2026

Benchmark Results

Hyperfine

Command Mean [ms] Min [ms] Max [ms] Relative
large_sir::baseline 2.8 ± 0.0 2.7 2.9 1.00
large_sir::entities 11.7 ± 0.3 11.5 13.2 4.18 ± 0.11

Criterion

Regressions (slower)
Group Bench Param Change CI Lower CI Upper
large_dataset bench_match_entity 18.567% 16.473% 20.952%
large_dataset bench_query_population_derived_property_entities 7.824% 7.414% 8.124%
indexing with_query_results_indexed_multi-property_entities 3.826% 3.259% 4.290%
sample_entity sample_entity_whole_population 100000 3.548% 2.605% 5.038%
sample_entity sample_entity_whole_population 1000 3.138% 2.693% 3.646%
sample_entity sample_entity_single_property_unindexed 1000 3.009% 2.210% 3.914%
algorithm_benches algorithm_sampling_multiple_l_reservoir 2.915% 2.271% 3.570%
sampling sampling_multiple_known_length_entities 2.555% 1.919% 3.281%
sample_entity sample_entity_whole_population 10000 2.471% 1.405% 3.270%
indexing query_people_count_indexed_multi-property_entities 2.303% 2.025% 2.576%
Improvements (faster)
Group Bench Param Change CI Lower CI Upper
examples example-basic-infection -29.072% -29.510% -28.571%
counts concrete_plus_derived_unindexed_entities -22.502% -23.340% -21.491%
sample_entity sample_entity_single_property_unindexed 10000 -17.514% -18.943% -15.915%
indexing query_people_single_indexed_property_entities -7.342% -7.572% -7.074%
indexing query_people_multiple_individually_indexed_properties_entities -6.125% -6.826% -5.395%
indexing query_people_indexed_multi-property_entities -5.511% -5.959% -5.071%
counts multi_property_unindexed_entities -5.418% -6.716% -4.155%
sampling sampling_single_unindexed_concrete_plus_derived_entities -2.877% -3.273% -2.481%
large_dataset bench_query_population_multi_unindexed_entities -2.238% -2.684% -1.899%
indexing query_people_count_multiple_individually_indexed_properties_enti -1.872% -2.220% -1.516%
sampling sampling_multiple_l_reservoir_entities -1.850% -2.206% -1.486%
algorithm_benches algorithm_sampling_single_rand_reservoir -1.614% -1.903% -1.304%
Unchanged / inconclusive (CI crosses 0%)
Group Bench Param Change CI Lower CI Upper
sampling sampling_single_known_length_entities -2.095% -4.110% -0.581%
counts single_property_unindexed_entities -1.626% -2.396% -0.850%
sampling count_and_sampling_single_known_length_entities 1.457% 0.796% 2.029%
sampling sampling_single_l_reservoir_entities 1.308% 0.516% 2.067%
counts multi_property_indexed_entities -1.153% -2.018% 0.159%
sample_entity sample_entity_single_property_indexed 10000 1.046% 0.694% 1.494%
indexing with_query_results_multiple_individually_indexed_properties_enti 1.041% 0.573% 1.538%
large_dataset bench_query_population_indexed_property_entities -1.001% -1.411% -0.437%
large_dataset bench_query_population_multi_indexed_entities -0.990% -1.619% -0.302%
sample_entity sample_entity_single_property_indexed 1000 0.984% 0.583% 1.530%
counts index_after_adding_entities 0.969% 0.829% 1.115%
large_dataset bench_filter_indexed_entity 0.869% -6.236% 8.886%
sampling sampling_single_unindexed_entities -0.666% -0.824% -0.460%
sampling sampling_multiple_unindexed_entities -0.656% -0.925% -0.410%
sample_entity sample_entity_multi_property_indexed 10000 -0.555% -0.764% -0.283%
sample_entity sample_entity_multi_property_indexed 100000 -0.537% -0.759% -0.348%
examples example-births-deaths -0.451% -0.729% -0.191%
large_dataset bench_filter_unindexed_entity 0.382% -2.783% 3.531%
counts single_property_indexed_entities -0.379% -0.728% 0.049%
indexing query_people_count_single_indexed_property_entities -0.362% -0.852% 0.057%
sampling count_and_sampling_single_unindexed_concrete_plus_derived_entiti 0.335% 0.108% 0.545%
sample_entity sample_entity_single_property_indexed 100000 0.271% -1.603% 1.543%
algorithm_benches algorithm_sampling_multiple_known_length -0.246% -0.850% 0.346%
indexing with_query_results_single_indexed_property_entities -0.227% -0.803% 0.350%
large_dataset bench_query_population_property_entities -0.214% -0.914% 0.800%
sample_entity sample_entity_single_property_unindexed 100000 -0.198% -0.387% 0.038%
algorithm_benches algorithm_sampling_single_l_reservoir 0.159% 0.012% 0.353%
counts reindex_after_adding_more_entities 0.067% -0.119% 0.244%
algorithm_benches algorithm_sampling_single_known_length -0.065% -0.523% 0.236%
sample_entity sample_entity_multi_property_indexed 1000 -0.047% -0.243% 0.129%

Copy link
Copy Markdown
Collaborator

@RobertJacobsonCDC RobertJacobsonCDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check me on this, but I think the tests in profiling::reporting are still relevant if the reporting feature is disabled. I think the API being exercised is still callable in that case.

Comment thread src/profiling/reporting.rs
@cdc-as81 cdc-as81 linked an issue Apr 7, 2026 that may be closed by this pull request
github-actions Bot added a commit that referenced this pull request Apr 9, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 9, 2026

Benchmark Results

Hyperfine

Command Mean [ms] Min [ms] Max [ms] Relative
large_sir::baseline 2.8 ± 0.0 2.8 2.9 1.00
large_sir::entities 12.1 ± 0.6 11.7 13.9 4.32 ± 0.21

Criterion

Regressions (slower)
Group Bench Param Change CI Lower CI Upper
sampling count_and_sampling_single_unindexed_concrete_plus_derived_entiti 7.197% 5.458% 9.077%
large_dataset bench_match_entity 6.552% 6.233% 6.792%
counts multi_property_indexed_entities 4.073% 3.478% 4.589%
sampling sampling_multiple_known_length_entities 3.340% 2.924% 3.644%
sample_entity sample_entity_whole_population 10000 2.507% 1.904% 2.995%
sample_entity sample_entity_whole_population 100000 2.279% 1.142% 3.102%
sample_entity sample_entity_single_property_unindexed 1000 1.880% 1.176% 2.531%
counts index_after_adding_entities 1.856% 1.682% 2.005%
Improvements (faster)
Group Bench Param Change CI Lower CI Upper
examples example-basic-infection -23.588% -23.813% -23.366%
indexing query_people_single_indexed_property_entities -20.173% -20.544% -19.935%
sample_entity sample_entity_single_property_unindexed 10000 -8.568% -9.261% -7.856%
indexing query_people_indexed_multi-property_entities -8.245% -8.782% -7.852%
sample_entity sample_entity_multi_property_indexed 100000 -5.505% -6.000% -5.115%
sample_entity sample_entity_multi_property_indexed 10000 -5.091% -5.646% -4.636%
sample_entity sample_entity_multi_property_indexed 1000 -4.444% -4.803% -3.987%
examples example-births-deaths -3.370% -3.547% -3.191%
counts reindex_after_adding_more_entities -1.824% -2.406% -1.321%
counts single_property_indexed_entities -1.800% -2.371% -1.253%
indexing query_people_count_indexed_multi-property_entities -1.781% -2.259% -1.249%
sampling sampling_single_l_reservoir_entities -1.757% -2.472% -1.149%
Unchanged / inconclusive (CI crosses 0%)
Group Bench Param Change CI Lower CI Upper
large_dataset bench_filter_indexed_entity 1.723% -6.078% 10.209%
sample_entity sample_entity_single_property_indexed 1000 -1.692% -2.683% -0.845%
sampling sampling_single_known_length_entities 1.505% 0.880% 2.088%
sampling sampling_multiple_l_reservoir_entities 1.368% 0.511% 2.266%
sample_entity sample_entity_whole_population 1000 1.231% -1.296% 3.783%
sample_entity sample_entity_single_property_indexed 10000 1.190% 0.144% 2.515%
large_dataset bench_filter_unindexed_entity 1.140% -2.432% 4.502%
counts multi_property_unindexed_entities 1.103% -0.718% 3.415%
large_dataset bench_query_population_derived_property_entities 1.030% 0.507% 1.458%
sample_entity sample_entity_single_property_unindexed 100000 1.000% 0.486% 1.454%
counts concrete_plus_derived_unindexed_entities -0.935% -1.793% -0.283%
sampling sampling_single_unindexed_entities 0.891% 0.593% 1.235%
large_dataset bench_query_population_property_entities 0.883% -0.087% 1.955%
sample_entity sample_entity_single_property_indexed 100000 0.815% -0.147% 1.973%
counts single_property_unindexed_entities -0.512% -1.043% -0.114%
sampling count_and_sampling_single_known_length_entities -0.483% -1.136% 0.184%
indexing query_people_count_single_indexed_property_entities -0.466% -0.917% -0.026%
sampling sampling_multiple_unindexed_entities 0.466% 0.235% 0.740%
indexing with_query_results_multiple_individually_indexed_properties_enti 0.460% -0.013% 0.860%
large_dataset bench_query_population_multi_indexed_entities -0.427% -0.763% -0.091%
indexing with_query_results_single_indexed_property_entities 0.322% -0.132% 0.853%
algorithm_benches algorithm_sampling_single_l_reservoir -0.309% -0.477% -0.152%
algorithm_benches algorithm_sampling_multiple_known_length -0.304% -0.690% 0.148%
sampling sampling_single_unindexed_concrete_plus_derived_entities 0.226% -0.846% 1.458%
indexing with_query_results_indexed_multi-property_entities 0.202% -0.261% 0.532%
algorithm_benches algorithm_sampling_single_rand_reservoir -0.172% -0.318% -0.041%
large_dataset bench_query_population_multi_unindexed_entities 0.116% -1.402% 1.667%
algorithm_benches algorithm_sampling_multiple_l_reservoir -0.115% -0.379% 0.167%
indexing query_people_multiple_individually_indexed_properties_entities -0.072% -0.202% 0.069%
large_dataset bench_query_population_indexed_property_entities 0.060% -0.855% 1.055%
indexing query_people_count_multiple_individually_indexed_properties_enti 0.048% -0.103% 0.238%
algorithm_benches algorithm_sampling_single_known_length -0.016% -0.417% 0.463%

@cdc-as81 cdc-as81 merged commit 651c501 into main Apr 9, 2026
22 checks passed
@cdc-as81 cdc-as81 deleted the cdc-as81-turn-off-profiling-by-default branch April 9, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Turn off profiling by default

3 participants