Skip to content

chore: remove double validate on add global prop#891

Merged
cdc-as81 merged 1 commit into
mainfrom
cdc-as81-remove-double-validate-on-add-global-prop
May 12, 2026
Merged

chore: remove double validate on add global prop#891
cdc-as81 merged 1 commit into
mainfrom
cdc-as81-remove-double-validate-on-add-global-prop

Conversation

@cdc-as81
Copy link
Copy Markdown
Collaborator

No description provided.

@cdc-as81 cdc-as81 linked an issue May 12, 2026 that may be closed by this pull request
github-actions Bot added a commit that referenced this pull request May 12, 2026
@github-actions
Copy link
Copy Markdown

Benchmark Results

Hyperfine

Command Mean [ms] Min [ms] Max [ms] Relative
large_sir::baseline 2.3 ± 0.0 2.3 2.4 1.00
large_sir::entities 5.3 ± 0.1 5.1 5.5 2.30 ± 0.05

Criterion

Regressions (slower)
Group Bench Param Change CI Lower CI Upper
counts single_property_indexed_entities 19.357% 18.045% 20.659%
indexing query_people_indexed_multi-property_entities 11.466% 9.784% 13.159%
examples example-births-deaths 6.304% 6.057% 6.549%
large_dataset bench_match_entity 6.173% 5.562% 6.777%
large_dataset bench_query_population_multi_indexed_entities 5.728% 5.195% 6.213%
sampling sampling_single_unindexed_concrete_plus_derived_entities 5.712% 4.631% 6.714%
sample_entity sample_entity_single_property_indexed 10000 5.343% 4.520% 6.277%
large_dataset bench_query_population_derived_property_entities 4.576% 4.149% 5.048%
sample_entity sample_entity_whole_population 100000 4.033% 1.124% 7.545%
sample_entity sample_entity_single_property_indexed 1000 3.730% 3.172% 4.322%
indexing with_query_results_multiple_individually_indexed_properties_enti 2.858% 2.658% 3.078%
sample_entity sample_entity_multi_property_indexed 100000 2.846% 2.391% 3.323%
indexing query_people_count_indexed_multi-property_entities 2.786% 1.461% 4.101%
counts multi_property_indexed_entities 1.950% 1.015% 2.657%
Improvements (faster)
Group Bench Param Change CI Lower CI Upper
large_dataset bench_filter_unindexed_entity -15.444% -19.653% -10.992%
counts multi_property_unindexed_entities -3.162% -3.552% -2.839%
indexing query_people_count_single_indexed_property_entities -2.489% -2.835% -2.248%
indexing query_people_multiple_individually_indexed_properties_entities -1.371% -1.500% -1.213%
Unchanged / inconclusive (CI crosses 0%)
Group Bench Param Change CI Lower CI Upper
sampling sampling_multiple_l_reservoir_entities -1.095% -1.246% -0.928%
sample_entity sample_entity_multi_property_indexed 1000 -1.076% -1.685% -0.338%
indexing query_people_single_indexed_property_entities -1.063% -1.217% -0.931%
sampling count_and_sampling_single_unindexed_concrete_plus_derived_entiti -0.937% -1.088% -0.780%
sample_entity sample_entity_single_property_indexed 100000 0.839% 0.333% 1.358%
large_dataset bench_query_population_property_entities -0.762% -2.127% 0.131%
counts single_property_unindexed_entities -0.756% -1.635% -0.040%
sampling sampling_single_l_reservoir_entities -0.735% -0.873% -0.599%
algorithm_benches algorithm_sampling_multiple_known_length -0.697% -1.031% -0.348%
sample_entity sample_entity_multi_property_indexed 10000 0.655% -0.482% 2.024%
indexing with_query_results_single_indexed_property_entities -0.653% -1.184% -0.067%
algorithm_benches algorithm_sampling_single_known_length -0.639% -0.853% -0.410%
sampling sampling_multiple_known_length_entities -0.631% -1.083% -0.008%
sample_entity sample_entity_single_property_unindexed 10000 0.620% 0.049% 1.143%
sample_entity sample_entity_whole_population 10000 0.606% 0.142% 1.034%
counts index_after_adding_entities 0.557% 0.234% 0.835%
algorithm_benches algorithm_sampling_single_l_reservoir -0.547% -0.769% -0.372%
counts concrete_plus_derived_unindexed_entities 0.513% 0.173% 0.750%
large_dataset bench_filter_indexed_entity -0.505% -12.202% 13.381%
indexing query_people_count_multiple_individually_indexed_properties_enti -0.468% -0.584% -0.277%
sampling count_and_sampling_single_known_length_entities -0.433% -2.686% 1.492%
counts reindex_after_adding_more_entities 0.415% 0.203% 0.611%
indexing with_query_results_indexed_multi-property_entities 0.410% 0.125% 0.612%
sample_entity sample_entity_single_property_unindexed 100000 -0.358% -0.755% 0.019%
algorithm_benches algorithm_sampling_multiple_l_reservoir -0.313% -0.487% -0.114%
sample_entity sample_entity_single_property_unindexed 1000 -0.299% -0.822% 0.198%
sample_entity sample_entity_whole_population 1000 0.241% -0.245% 0.779%
large_dataset bench_query_population_multi_unindexed_entities -0.159% -0.720% 0.238%
sampling sampling_single_known_length_entities -0.158% -0.767% 0.581%
sampling sampling_single_unindexed_entities 0.112% 0.015% 0.246%
sampling sampling_multiple_unindexed_entities -0.092% -0.195% -0.011%
algorithm_benches algorithm_sampling_single_rand_reservoir -0.088% -0.184% 0.007%
large_dataset bench_query_population_indexed_property_entities 0.083% -0.260% 0.649%
examples example-basic-infection 0.074% -0.304% 0.388%

@RobertJacobsonCDC RobertJacobsonCDC changed the title chore: remove double vaidate on add global prop chore: remove double validate on add global prop May 12, 2026
Copy link
Copy Markdown
Collaborator

@RobertJacobsonCDC RobertJacobsonCDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdc-as81 cdc-as81 merged commit 8d2b278 into main May 12, 2026
23 checks passed
@cdc-as81 cdc-as81 deleted the cdc-as81-remove-double-validate-on-add-global-prop branch May 12, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validation of inputs is performed twice in define_global_property!

3 participants