Skip to content

chore: impl Deserialize for properties#899

Merged
RobertJacobsonCDC merged 1 commit into
mainfrom
RobertJacobsonCDC_898_deserialize_property
May 18, 2026
Merged

chore: impl Deserialize for properties#899
RobertJacobsonCDC merged 1 commit into
mainfrom
RobertJacobsonCDC_898_deserialize_property

Conversation

@RobertJacobsonCDC
Copy link
Copy Markdown
Collaborator

The define_*_property! macros now derive serde::Deserialize for the property.

@RobertJacobsonCDC RobertJacobsonCDC linked an issue May 15, 2026 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown

Benchmark Results

Hyperfine

Command Mean [ms] Min [ms] Max [ms] Relative
large_sir::baseline 2.8 ± 0.1 2.8 3.1 1.00
large_sir::entities 6.4 ± 0.2 6.3 7.9 2.27 ± 0.09

Criterion

Regressions (slower)
Group Bench Param Change CI Lower CI Upper
sample_entity sample_entity_single_property_unindexed 1000 18.844% 16.324% 21.399%
large_dataset bench_query_population_indexed_property_entities 18.530% 15.924% 21.399%
examples example-births-deaths 12.350% 12.093% 12.605%
indexing with_query_results_multiple_individually_indexed_properties_enti 12.225% 11.519% 12.852%
indexing with_query_results_indexed_multi-property_entities 8.360% 7.329% 9.737%
indexing query_people_count_indexed_multi-property_entities 7.062% 6.766% 7.461%
sample_entity sample_entity_whole_population 10000 6.940% 6.446% 7.397%
examples example-basic-infection 6.151% 4.766% 7.661%
counts single_property_indexed_entities 6.082% 5.059% 7.083%
sampling sampling_single_known_length_entities 5.276% 4.453% 6.128%
sampling count_and_sampling_single_known_length_entities 3.428% 2.784% 3.966%
algorithm_benches algorithm_sampling_multiple_known_length 3.221% 2.702% 3.698%
algorithm_benches algorithm_sampling_multiple_l_reservoir 2.655% 2.397% 2.890%
sample_entity sample_entity_single_property_unindexed 10000 2.049% 1.014% 3.255%
algorithm_benches algorithm_sampling_single_known_length 1.745% 1.050% 2.576%
Improvements (faster)
Group Bench Param Change CI Lower CI Upper
large_dataset bench_match_entity -38.383% -39.288% -37.473%
indexing query_people_count_single_indexed_property_entities -7.333% -8.148% -6.531%
sampling sampling_single_unindexed_concrete_plus_derived_entities -4.652% -5.358% -3.925%
sampling sampling_single_unindexed_entities -4.387% -4.764% -3.978%
sample_entity sample_entity_multi_property_indexed 10000 -4.387% -4.624% -4.170%
sample_entity sample_entity_multi_property_indexed 1000 -3.680% -3.892% -3.455%
sampling count_and_sampling_single_unindexed_concrete_plus_derived_entiti -3.408% -3.899% -2.907%
indexing query_people_multiple_individually_indexed_properties_entities -3.378% -4.017% -2.654%
sampling sampling_multiple_l_reservoir_entities -2.403% -2.524% -2.299%
sampling sampling_single_l_reservoir_entities -1.845% -2.668% -1.209%
counts reindex_after_adding_more_entities -1.698% -2.066% -1.323%
Unchanged / inconclusive (CI crosses 0%)
Group Bench Param Change CI Lower CI Upper
large_dataset bench_filter_indexed_entity -1.879% -9.855% 7.386%
large_dataset bench_query_population_derived_property_entities -1.836% -3.099% -0.735%
sample_entity sample_entity_multi_property_indexed 100000 -1.370% -1.646% -0.994%
indexing query_people_count_multiple_individually_indexed_properties_enti -1.307% -1.869% -0.740%
indexing with_query_results_single_indexed_property_entities -1.297% -1.696% -0.961%
counts index_after_adding_entities -0.902% -1.137% -0.670%
sample_entity sample_entity_single_property_indexed 10000 -0.878% -1.114% -0.624%
counts multi_property_unindexed_entities 0.766% -0.407% 2.552%
large_dataset bench_filter_unindexed_entity -0.634% -3.825% 2.868%
sample_entity sample_entity_whole_population 100000 0.612% 0.212% 0.930%
large_dataset bench_query_population_multi_unindexed_entities 0.548% -0.118% 1.351%
large_dataset bench_query_population_multi_indexed_entities -0.505% -0.970% -0.021%
sampling sampling_multiple_known_length_entities 0.409% -0.065% 0.993%
indexing query_people_indexed_multi-property_entities 0.393% -0.097% 0.965%
counts single_property_unindexed_entities 0.358% -0.124% 0.872%
sample_entity sample_entity_single_property_indexed 1000 0.330% 0.012% 0.654%
indexing query_people_single_indexed_property_entities 0.305% 0.204% 0.396%
counts concrete_plus_derived_unindexed_entities -0.297% -0.757% 0.045%
counts multi_property_indexed_entities -0.274% -1.195% 0.480%
large_dataset bench_query_population_property_entities 0.247% -0.104% 0.696%
sample_entity sample_entity_single_property_unindexed 100000 -0.212% -0.404% -0.025%
sample_entity sample_entity_single_property_indexed 100000 0.137% -0.439% 0.790%
sample_entity sample_entity_whole_population 1000 0.119% -0.307% 0.700%
sampling sampling_multiple_unindexed_entities -0.065% -0.723% 0.561%
algorithm_benches algorithm_sampling_single_rand_reservoir 0.063% -0.253% 0.462%
algorithm_benches algorithm_sampling_single_l_reservoir 0.040% -0.150% 0.215%
Not Compared (no baseline yet)
Group Bench Reason
(none)

github-actions Bot added a commit that referenced this pull request May 15, 2026
@RobertJacobsonCDC RobertJacobsonCDC merged commit 0c2c507 into main May 18, 2026
22 checks passed
@RobertJacobsonCDC RobertJacobsonCDC deleted the RobertJacobsonCDC_898_deserialize_property branch May 18, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Deserialize for properties in define_*_property

3 participants