Skip to content

Map Page UI Updates#175

Merged
mwodahl merged 125 commits intoUpdate/ui-themefrom
Update/webapp-map-ui
Apr 29, 2025
Merged

Map Page UI Updates#175
mwodahl merged 125 commits intoUpdate/ui-themefrom
Update/webapp-map-ui

Conversation

@mwodahl
Copy link
Copy Markdown

@mwodahl mwodahl commented Feb 27, 2025

PR Details

This PR updates the map page to include the UI updates found in the following Figma prototype: https://www.figma.com/proto/QG64ugNXpXMUk2vQ1wgPdZ/CV-Manager-Prototype-January-2025?page-id=2143%3A6061&node-id=2146-7749&viewport=-595%2C-659%2C0.22&t=A1CuORABoO0Qexzk-1&scaling=scale-down&content-scaling=fixed&starting-point-node-id=2146%3A6646

Description

This PR includes the following changes:

  • Update menu opacity and background color
  • Update RSU popup to include color-coded information and icon
  • Update RSU configuration menus (single and multiple) with correct layout, button types
  • Update the counts menu input display
  • Update the RSU Status component to include color-coded information, location icon, and correct button variations

How Has This Been Tested?

This was tested locally using docker compose alongside the changes found in #172. Unit tests were verified to pass using npm.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • [ X ] New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • My changes require new environment variables:
    • I have updated the docker-compose, K8s YAML, and all dependent deployment configuration files.
  • My changes require updates to the documentation:
    • I have updated the documentation accordingly.
  • [ X ] My changes require updates and/or additions to the unit tests:
    • [ X ] I have modified/added tests to cover my changes.
  • [ X ] All existing tests pass.

jacob6838 and others added 30 commits January 17, 2025 10:45
Co-authored-by: Matt Cook <mattheworion.cook@gmail.com>
@mwodahl
Copy link
Copy Markdown
Author

mwodahl commented Apr 23, 2025

Talked offline, but the error report print should include RSUs in the error state. Otherwise this looks great!

This has been updated and now includes RSUs that are in an error state

@mwodahl mwodahl requested a review from payneBrandon April 23, 2025 18:35
@mwodahl mwodahl requested a review from jacob6838 April 24, 2025 14:24
@jacob6838
Copy link
Copy Markdown
Collaborator

The green success text on the RSU reboot menu is very difficult to read in dark mode:

image

@jacob6838
Copy link
Copy Markdown
Collaborator

The WZDx dialog overflows a bit:
image

@jacob6838
Copy link
Copy Markdown
Collaborator

I noticed some transparent gaps in the map menu as well:
image

@mwodahl
Copy link
Copy Markdown
Author

mwodahl commented Apr 25, 2025

@jacob6838 I've updated the RSU reboot menu success color, fixed the WZDx popup overflow, and fixed the transparent divider issue

@jacob6838
Copy link
Copy Markdown
Collaborator

Ok, last 2 comments:

  1. The RSU update menu error text is hard to read:
image 2. The RSU configuration menu hover outline isn't quite in the right spot, and the items are a little close together (top left index is really close to the other entry, and delete button is very low)

@mwodahl
Copy link
Copy Markdown
Author

mwodahl commented Apr 25, 2025

Ok, last 2 comments:

  1. The RSU update menu error text is hard to read:

image 2. The RSU configuration menu hover outline isn't quite in the right spot, and the items are a little close together (top left index is really close to the other entry, and delete button is very low)

I've updated the RSU update menu error/success text to use the light variants, which makes the text much easier to read. I've also removed the set height from the configuration menu items, which fixes the hover issue and adds more space between items.

Copy link
Copy Markdown
Collaborator

@jacob6838 jacob6838 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, this looks really good!

@mwodahl mwodahl merged commit e1beb7d into Update/ui-theme Apr 29, 2025
8 checks passed
@mwodahl mwodahl deleted the Update/webapp-map-ui branch April 29, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants