optimised _PrintUInt & _FillScreen#40
Merged
mateoconlechuga merged 2 commits intomasterfrom Nov 7, 2016
unknown repository
Merged
optimised _PrintUInt & _FillScreen#40mateoconlechuga merged 2 commits intomasterfrom unknown repository
mateoconlechuga merged 2 commits intomasterfrom
unknown repository
Conversation
added 2 commits
November 7, 2016 11:11
Slight optimisation of _PrintUInt, Propose to include a faster fillscreen when color is null
Collaborator
mateoconlechuga
left a comment
mateoconlechuga
left a comment
There was a problem hiding this comment.
The _FillScreen isn't an optimization.
adriweb
reviewed
Nov 7, 2016
| ; DE : New X coordinate | ||
| ; NC : If offscreen | ||
| ld ix,6 ; get pointer to arguments | ||
| ld iy,ix-6 |
Collaborator
There was a problem hiding this comment.
I'm just going to merge anyway and fix myself
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slight optimisation of _PrintUInt,
Propose to include a faster fillscreen when color is null