This repository was archived by the owner on Mar 26, 2022. It is now read-only.
Group conversation #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 1, 2016 16:05
Message Model now has issuedTo and the messageKey variable Conversation Model now has a list of messages that contains a list of message instead of just a list of message. Allowed the storage of different messageKeys for different users.
Member
|
Niiiccceeeee! :D thanks dude! From my latest commit, I should just be able to update the way messages are handled, and we should be good to go! |
torch2424
approved these changes
Dec 2, 2016
Member
torch2424
left a comment
torch2424
left a comment
There was a problem hiding this comment.
Code looks good! Sucks we're on a time restraint! And, like the professor said, don't forget to comment stuff :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #68
Closes #69
Closes #70
Tested using postman check comments for json output.
@torch2424 Also, the body for creating and updating conversations has changed. Make sure to check that in the wiki.