Skip to content

Added Caliper annotations for Laghos solver Serial version#208

Closed
amroakmal wants to merge 1 commit intoCEED:masterfrom
amroakmal:add-caliper-instrumentation-to-serial-laghos-solver
Closed

Added Caliper annotations for Laghos solver Serial version#208
amroakmal wants to merge 1 commit intoCEED:masterfrom
amroakmal:add-caliper-instrumentation-to-serial-laghos-solver

Conversation

@amroakmal
Copy link

Added Caliper annotations around the timed sections of the Serial Laghos Solver

@amroakmal
Copy link
Author

@rfhaque @michaelmckinsey1 Please review. The goal is to add Caliper annotations for the serial Laghos version.

@rfhaque
Copy link
Contributor

rfhaque commented Mar 4, 2026

@amroakmal This looks good to me

@vladotomov
Copy link
Member

@amroakmal @rfhaque I'm not sure what's the purpose here, but keep in mind that the code in /serial has not been kept in sync with the top directory for a long time. How are you using this and do you expect it to behave the same way as the baseline parallel Laghos?

@pearce8 pearce8 mentioned this pull request Mar 5, 2026
27 tasks
@amroakmal
Copy link
Author

amroakmal commented Mar 11, 2026

We experimented running the serial code and confirmed that its not executed at all, we tested across the eight different Laghos problems. Attached are Caliper call-trees. Closing this PR.
FYI @slabasan @michaelmckinsey1 @rfhaque

Screenshot 2026-03-09 at 2 44 16 PM Screenshot 2026-03-09 at 1 25 24 PM Screenshot 2026-03-09 at 1 29 13 PM Screenshot 2026-03-09 at 1 29 36 PM Screenshot 2026-03-09 at 1 29 56 PM Screenshot 2026-03-09 at 1 30 27 PM Screenshot 2026-03-09 at 1 30 51 PM Screenshot 2026-03-09 at 1 17 36 PM

@amroakmal amroakmal closed this Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants