HIP: Add support for HIP 7+#1969
Merged
Merged
Conversation
…ault on initialized vector
- stddef.h is no longer supported - int types have been moved to the __hip_internal namespace
jeremylt
reviewed
May 21, 2026
jeremylt
reviewed
May 21, 2026
jeremylt
reviewed
May 21, 2026
jeremylt
reviewed
May 21, 2026
Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>
zatkins-dev
force-pushed
the
zach/rocm-7-fixes
branch
from
b210015 to
4dd9e2c
Compare
jeremylt
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose:
Update libCEED to support ROCm 7+
Specific changes:
-lhiprtclibrary explicitly nowNULLtonullptrin JiT sourcesint32_tandint64_tfrom the__hip_internalnamespaceCloses: NA
LLM/GenAI Disclosure:
I used Gemini to generate the cut command in the makefile, pretty embarrassing in hindsight.