Fluids - update mesh creating and remove problem-specific BCs#881
Merged
Fluids - update mesh creating and remove problem-specific BCs#881
Conversation
laylagi
force-pushed
the
leila/fluids-mesh
branch
from
131d21c to
e28d7d6
Compare
jeremylt
reviewed
Jan 27, 2022
laylagi
force-pushed
the
leila/fluids-mesh
branch
from
e28d7d6 to
b5a9f3b
Compare
jeremylt
reviewed
Jan 27, 2022
laylagi
force-pushed
the
leila/fluids-mesh
branch
from
88cd6fc to
51bd8c6
Compare
Factor out euler_outflow QFunction to be used in different problem cases
jedbrown
force-pushed
the
leila/fluids-mesh
branch
from
423e36f to
496f238
Compare
jedbrown
approved these changes
Feb 1, 2022
Member
jedbrown
left a comment
jedbrown
left a comment
There was a problem hiding this comment.
I rebased on main so we can use new PETSc. I think we can merge once the pipeline passes.
Member
|
Erm, I missed that the |
Member
|
What do you make of these HIP-only test failures? https://gitlab.com/libceed/libCEED/-/pipelines/461302258/test_report I think the lv test failures are just needing a PETSc update from @jeremylt |
jedbrown
approved these changes
Feb 2, 2022
Member
jedbrown
left a comment
jedbrown
left a comment
There was a problem hiding this comment.
Thanks. Looks good to me. In the future, we'll want to allow slip boundaries that are not grid aligned. This is subtle on curved boundaries, but the normal would be obtained from quadrature points (and thus the user won't need to specify the normal).
laylagi
force-pushed
the
leila/fluids-mesh
branch
from
af0f6ec to
249cce9
Compare
laylagi
force-pushed
the
leila/fluids-mesh
branch
from
249cce9 to
55e7655
Compare
jeremylt
reviewed
Feb 2, 2022
|
|
||
| #include <math.h> | ||
|
|
||
| #ifndef euler_context_struct |
Member
There was a problem hiding this comment.
To make this work the way you want, you would need to put the struct in a third file and include it in both qfunction headers.
Member
Author
There was a problem hiding this comment.
Thanks @jeremylt for the hint. I will go ahead and merge this since we don't need to split the headers right now. We can split them when we add other problems that use euler_outflow.
laylagi
added a commit
that referenced
this pull request
Feb 24, 2022
laylagi
added a commit
that referenced
this pull request
Feb 26, 2022
jedbrown
added a commit
that referenced
this pull request
May 5, 2022
* Implemented the Sod Shock Tube problem with YZB discontinuity capturing. for the explicit formulation. SU stabilization is also implemented for the explicit formulation. * Changed variable name midpt to mid_point, removed redundant slip BC declarations. * Fixed style error, made variable names clearer, and removed dead code. * Missed a style fix * Rebased with main * Implemented the Sod Shock Tube problem with YZB discontinuity capturing. for the explicit formulation. SU stabilization is also implemented for the explicit formulation. * Fixed style error, made variable names clearer, and removed dead code. * Missed a style fix * Implemented fixes to the flux jacobians * Updated documentation, tau definition in SU, and recommended fixes to the flux Jacobian. * Implemented the Sod Shock Tube problem with YZB discontinuity capturing. for the explicit formulation. SU stabilization is also implemented for the explicit formulation. * Missed a style fix * Implemented the Sod Shock Tube problem with YZB discontinuity capturing. for the explicit formulation. SU stabilization is also implemented for the explicit formulation. * Fixes to style and documentation. * Fixing unnecessary problem->dim declaration and missing field in comment describing initial condition density. * Added warnings for incompatible user input combinations. * Added comments on beta to documentation, fixed j_gradn style issues. * Compilation errors on my end. Committing to see if it's local or not. * Style fixes * Implemented the Sod Shock Tube problem with YZB discontinuity capturing. for the explicit formulation. SU stabilization is also implemented for the explicit formulation. * Changed variable name midpt to mid_point, removed redundant slip BC declarations. * Fixed style error, made variable names clearer, and removed dead code. * Missed a style fix * Rebased with main * Implemented the Sod Shock Tube problem with YZB discontinuity capturing. for the explicit formulation. SU stabilization is also implemented for the explicit formulation. * Fixed style error, made variable names clearer, and removed dead code. * Missed a style fix * Implemented fixes to the flux jacobians * Updated documentation, tau definition in SU, and recommended fixes to the flux Jacobian. * Implemented the Sod Shock Tube problem with YZB discontinuity capturing. for the explicit formulation. SU stabilization is also implemented for the explicit formulation. * Missed a style fix * Implemented the Sod Shock Tube problem with YZB discontinuity capturing. for the explicit formulation. SU stabilization is also implemented for the explicit formulation. * Fixes to style and documentation. * Fixing unnecessary problem->dim declaration and missing field in comment describing initial condition density. * Added warnings for incompatible user input combinations. * Added comments on beta to documentation, fixed j_gradn style issues. * Compilation errors on my end. Committing to see if it's local or not. * Fluids: SETERRQ1 -> SETERRQ to be compatible with PETSc 3.17 * Fluids - Update shock-tube with #881 * Small fix to mid_point definition and removed repeat entries for Shock Tube problem in README.md. * Including test output. * Implemented the Sod Shock Tube problem with YZB discontinuity capturing. for the explicit formulation. SU stabilization is also implemented for the explicit formulation. * Changed variable name midpt to mid_point, removed redundant slip BC declarations. * Fixed style error, made variable names clearer, and removed dead code. * Missed a style fix * Rebased with main * Implemented the Sod Shock Tube problem with YZB discontinuity capturing. for the explicit formulation. SU stabilization is also implemented for the explicit formulation. * Fixed style error, made variable names clearer, and removed dead code. * Missed a style fix * Implemented fixes to the flux jacobians * Updated documentation, tau definition in SU, and recommended fixes to the flux Jacobian. * Implemented the Sod Shock Tube problem with YZB discontinuity capturing. for the explicit formulation. SU stabilization is also implemented for the explicit formulation. * Missed a style fix * Implemented the Sod Shock Tube problem with YZB discontinuity capturing. for the explicit formulation. SU stabilization is also implemented for the explicit formulation. * Fixes to style and documentation. * Fixing unnecessary problem->dim declaration and missing field in comment describing initial condition density. * Added warnings for incompatible user input combinations. * Added comments on beta to documentation, fixed j_gradn style issues. * Compilation errors on my end. Committing to see if it's local or not. * Fluids: SETERRQ1 -> SETERRQ to be compatible with PETSc 3.17 * Fluids - Update shock-tube with #881 * Fluids - added test output file for shocktube * Small fix to mid_point definition and removed repeat entries for Shock Tube problem in README.md. * Including test output. * Update doc/sphinx/source/references.bib Co-authored-by: Jed Brown <jed@jedbrown.org> * Update examples/fluids/README.md Co-authored-by: Jed Brown <jed@jedbrown.org> * Update examples/fluids/index.md Co-authored-by: Jed Brown <jed@jedbrown.org> * Update examples/fluids/navierstokes.h Co-authored-by: Jed Brown <jed@jedbrown.org> * Update examples/fluids/problems/shocktube.c Co-authored-by: Jed Brown <jed@jedbrown.org> * Update examples/fluids/qfunctions/shocktube.h Co-authored-by: Jed Brown <jed@jedbrown.org> * Removed unused IFunction * Added shocktube variables to SetupContext in advection.h, advection2d.h, and densitycurrent.h * Missed some merge conflicts that have now been cleared up. * Added helper function for covariant element length along a given vector. * Added SetupContext to shocktube.h * Fix to regression test path * remove variable transpose of the Jacobian * Fix index swap in implicit SUPG * examples/fluids shocktube: fix stab summation and transpose * delete IFunction * example/fluids- updates reference solution Co-authored-by: Timothy Aiken <timothyaiken@Timothys-MacBook-Pro.local> Co-authored-by: Timothy Aiken <timothyaiken@cu-biot-10-10.203.167.69.int.colorado.edu> Co-authored-by: Leila Ghaffari <Leila.Ghaffari@colorado.edu> Co-authored-by: Jed Brown <jed@jedbrown.org> Co-authored-by: Timothy Aiken <timothyaiken@cu-genvpn-tcom-10.180.164.177.int.colorado.edu> Co-authored-by: AdelekeBankole <adeleke.bankole@colorado.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the code related to creating meshes and sizing the domain is removed. The problem-specific BCs are also dropped. This will enable the user to specify wall, slip, inflow, and/or outflow BCs according to their own problem setup.
TODOs: