fix TagPileup tab-formatted output bug#42
Merged
WilliamKMLai merged 1 commit intomasterfrom Sep 15, 2020
Merged
Conversation
This commit fixes the bug described in issue #41. The problem was in the case of setting the output to be tab formatted, the Writer objects OUT_S1 and/or OUT_S2 failed to close. I adjusted the "if" statements for outputting JTV files (whose code fell under the same conditionals as the code responsible for closing the output Writer objects) so that they are consistent with previous conditions but included the case of PARAM.getOutputType()==1 for closing the Writer objects.
WilliamKMLai
approved these changes
Sep 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the bug described in issue #41. The problem was in
the case of setting the output to be tab formatted, the Writer
objects OUT_S1 and/or OUT_S2 failed to close.
I adjusted the "if" statements for outputting JTV files (whose code
fell under the same conditionals as the code responsible for closing
the output Writer objects) so that they are consistent with previous
conditions but included the case of PARAM.getOutputType()==1 for
closing the Writer objects.