Skip to content

Conversation

@ashhh97
Copy link
Contributor

@ashhh97 ashhh97 commented Aug 2, 2022

  1. index.html: add night mode background image.
  2. styles.module.css: add night mode style.
    3.custom.css: change night mode github svg to white.

… add night mode style. 3.custom.css: change night mode github svg to white
@ashhh97 ashhh97 requested a review from owlang August 2, 2022 14:26
ashhh97 and others added 7 commits August 4, 2022 14:29
1.commit new BAM-to-Bedgraph icon image with white background
2. BAM Indexer icon — commit image with rounded square border
3. add docusaurus/docs/figure-generation/three-color-heatmap.md outlined similar to other figure-generation docs (add three-color-heatmap label in sidebars.js)
4. add composite plot icon
5. Four-color plot under gallery should be replaced with a version that has labeled axes.
6. add MD5checsum tool screenshot of the tool window
add markdown file for color selection in Figure Generation tools via both GUI and CLI. Content is based on material from the "Command Line" guide which was moved to Color Guide and appropriate tool-specific markdown files.
Fill in content for each of the BAM Manipulation tools and standardize naming and syntax.

Rename and standardize the image naming format of the window screenshots.
Variables were renamed for specificity and clarity. "Dark Mode" versions of background images and formatting named using "dark mode."

Various assay-specific gallery information was named with consistent syntax (AssayInfo).

Gallery images renamed for clarity (DarkMode versions of images) an for consistency (Assay-specific gallery images now include assay name). Unused Docusaurus images removed.

Unused and redundant comments removed. Github will track old code and large chunks of commented code makes reading the Git diff files less clear.
The ChIP-exo, Genomic Features, and ATACseq tab of the figure gallery were a mix of hardcoded formatting. This commit creates a new "GalleryTab" function that inputs a single AssayInfo object and builds the gallery tab structure. All three assay can use this structure to display in the gallery. The image urls can be one or more (arranged using flex display).

Future work: consider turning "GalleryTab" into a component (`src/components/GalleryTab`) and fixing tutorial link to dynamically check for an href value to the tutorial.
Comment each function and constant

Redo gallery information objects (e.g. `DefaultInfo`, `ChipexoInfo`,...) to be *objects* rather than lists to remove redundant layer.

`GalleryTabContent` (renamed from `GalleryTab`) updated accordingly.
* function signature changed to accept object (`props`) directly instead of specific keyed items
* removed unused `imgUrl`
* variables changed to access from `props`
* minor formatting changes to add spaces and remove headers (tab titles serve as headers)
Similarity matrix and signal duplication tools not yet vetted for use so appropriate warnings have been added to the docs.
@owlang owlang merged commit e72f50e into master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants