Merged
Conversation
This relates to issue #66 where we are adding colors to enable the creation of a trace heatmap. The addition of this capability is fairly straightforward: -set the base image to fully transparent (white) -calculate an alpha gradient value for each square in the same way the red, green, and blue gradients are calculated -use this calculated alpha value to set the pixel-wise color -there are two places this is computed in three color heatmap so this will need to be updated in two places.
This adjustment to the TwoColorHeatMap script allows the heatmap graphics to use the alpha channel value for the color sent from the GUI and display custom levels of transparency to the heatmap colors. This is updated to mimic ThreeColorHeatMap changes (#66).
Both TwoColorHeatMap and ThreeColorHeatMap CLI should also handle alpha channel color values so that CLI mimics GUI functionality (#66). Both CLI contain lines that validate alpha value as numeric 0 to 255 and update the color's alpha channel. Their flags are related to the letter "t" for transparency. Also contains bug fix in ThreeColorHM such that more than one color can be specified in a single call (before there was a restriction imposed for one color being changed at a time). TwoColorHM was also adjusted to avoid redundancy. The check for custom color being selected occurred more than once so the hexcode decoding block was moved.
TwoColorHeatMapWindow -add checkbox for toggling background transparency TwoColorHeatMapOutput -pass along parameter flagging transparent background -remove leftover print statement (for output status flag) TwoColorHeatMap -add boolean parameter to toggle transparency of background by determining mincolor -minor fix to account for NaN values when determining quantiles TwoColorHeatMapCLI -add flag to support transparent background heatmaps -Remove extension requirements for Galaxy compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#66 add support for transparent backgrounds of both two-color and three-color heatmaps so we can support overlaying different heatmap traces with each other.