Skip to content

new evidence notification#251

Merged
mateodurante merged 1 commit into
developfrom
feature/notification_on_new_evidence
May 2, 2026
Merged

new evidence notification#251
mateodurante merged 1 commit into
developfrom
feature/notification_on_new_evidence

Conversation

@mateodurante
Copy link
Copy Markdown
Contributor

This pull request introduces a new feature for notifying users when evidence is added to cases or events, along with several related updates across the codebase and translation files. It also includes minor improvements to email template validation, new email templates, and updates to Spanish translations and test data.

New evidence notification feature:

  • Added logic in the CaseEvidence.save method to send notifications when new evidence is added to a case or event. The notification uses new email templates and is triggered only on evidence creation.
  • Registered new email templates (new_evidence_added_to_event and new_evidence_added_to_case) in the EMAIL_TEMPLATES mapping in email_handler.py.
  • Added corresponding HTML templates for the new evidence notification emails: new_evidence_added_to_case.html and new_evidence_added_to_event.html. [1] [2]
  • Updated Spanish translation file (django.po) with new strings and translations for the evidence notification feature.

Improvements and fixes:

  • Improved error messaging in send_email by including the invalid template name in the exception.
  • Updated various translation strings and line references in the Spanish locale file to reflect recent code changes and improve consistency. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]

Testing and test data updates:

  • Updated test imports and fixtures to support email testing and artifact uploads. [1] [2]
  • Changed test data for event notes in multiple test cases from Spanish to English to maintain consistency. [1] [2] [3] [4] [5]

Copilot AI review requested due to automatic review settings April 28, 2026 18:52
@mateodurante mateodurante merged commit 2051b68 into develop May 2, 2026
6 checks passed
mateodurante added a commit that referenced this pull request May 13, 2026
* feat: Implement Analyzer and AnalyzerMapping models with associated s… (#250)

* feat: Implement Analyzer and AnalyzerMapping models with associated serializers and views

- Added Analyzer model with fields for name, type, enabled status, config, and description.
- Created AnalyzerMapping model with foreign key to Analyzer and fields for mapping_from and mapping_to.
- Developed serializers for both models to handle validation and representation.
- Introduced viewsets for Analyzer and AnalyzerMapping, including custom actions for testing connections and retrieving vulnerability choices.
- Updated event retesting functionality to support analyzer mappings, allowing for dynamic selection of analyzers during event retests.
- Enhanced frontend component to utilize dropdown for selecting analyzers when retesting events.
- Added filters for Analyzer and AnalyzerMapping models to improve query capabilities.
- Implemented migrations for new models and relationships, ensuring database integrity.
- Created unit tests for Analyzer and AnalyzerMapping models to validate functionality and constraints.

Co-authored-by: Copilot <copilot@github.com>

* Potential fix for pull request finding 'CodeQL / Information exposure through an exception'

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* Update ngen/analyzers/kintun.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update frontend/src/views/analyzer/components/FormAnalyzer.jsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* feat: Make analyzer selection required in Create and Edit Analyzer Mapping forms; update KintunAdapter to disable redirects and improve error logging

Co-authored-by: Copilot <copilot@github.com>

* feat: Refactor analyzer configuration to include port and SSL options; update translations and form handling

---------

Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* new evidence notification (#251)

* cleanup translations (#252)

* fix: agrega filtro select url (#253)

* fix: agrega filtro select url

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Fix: Avoid raise condition con sending email inside atomic transaction (#254)

* avoid raise condition con sending email inside atomic transaction

* better traceback

* tests fix for transaction on_commit

* fix entity too large nginx upload file

---------

Co-authored-by: Ulises Martín Cabrera <ucabrera@cert.unlp.edu.ar>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant