json_dump: Fixed output to stdout#220
Closed
vaclavbartos wants to merge 1 commit intomasterfrom
Closed
Conversation
The last commit (ab713e0), which added the option to stream data over TCP, broke the default output to TCP (stdout.write only accepts str, not bytes). Moreover, it used an undocumented socket.SocketIO object, which is not the best idea. This implements the TCP stream differently and reverts the changes done to the other output options, so all output types now work.
cejkato2
approved these changes
Mar 31, 2023
Contributor
Author
|
The fix was incorporated into #217 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last commit (ab713e0), which added the option to stream data over TCP, broke the default output to TCP (stdout.write only accepts str, not bytes). Moreover, it used an undocumented
socket.SocketIOobject, which is not the best idea.This implements the TCP stream differently and reverts the changes done to the other output options, so all output types now work.