Is it better to add err_path in nc_err_libyang when case is LYVE_NOCONSTR,LYVE_NOWHEN and default

[ZhaoGuangYue1986]

Is it better to add err_path in nc_err_libyang when case is LYVE_NOMUST, LYVE_NOCONSTR,LYVE_NOWHEN and default

[michalvasko]

Hi,
no reason not to, thanks.

Regards,
Michal

[ZhaoGuangYue1986]

@michalvasko
Hi, i think it is reasonable.
1.as an api in messages_server.h ,the function should construct complete error msg it knows not partly.
2.In the function, if the error is other case we set the error path, but only LYVE_NOMUST, LYVE_NOCONSTR,LYVE_NOWHEN we do not, it is doubtful,or it has other reasons?

Consider the err msg as below, when user config-data is not fit the pattern,it does not shows the error path. So ,the user do not know which leaf is error, it can not fix the errors.

type:     protocol
tag:      invalid-value
severity: error
message:  Value "ad10" does not satisfy the constraint "[A-Z_0-9]*" (range, length, or pattern).

[michalvasko]

Hi,
I am now a bit confused, have you tried it with the most recent libnetconf2 devel? Because I have made the change you suggested and it should even be seen in the netopeer2-cli output even though you only mentioned it just now.

Regards,
Michal

[ZhaoGuangYue1986]

Hi,
I am now a bit confused, have you tried it with the most recent libnetconf2 devel? Because I have made the change you suggested and it should even be seen in the netopeer2-cli output even though you only mentioned it just now.

Regards,
Michal

Thanks
It is my problem.
Sorry for my poor English ,i just think we do not need do this for understanding the first reply , .

[michalvasko]

Hi,
I have added the path for libyang errors LYVE_NOMUST, LYVE_NOCONSTR, and LYVE_NOWHEN to be stored in libnetconf2 error structure because I thought that is what you wanted. Did you want something else?

Regards,
Michal

[ZhaoGuangYue1986]

No
Thanks