Skip to content

fix and testcase for empty deviation parameter#140

Merged
michalvasko merged 1 commit intoCESNET:develfrom
ADTRAN:hello_cap_w_empty_deviation_param
Mar 14, 2019
Merged

fix and testcase for empty deviation parameter#140
michalvasko merged 1 commit intoCESNET:develfrom
ADTRAN:hello_cap_w_empty_deviation_param

Conversation

@frimpler
Copy link
Copy Markdown
Contributor

@frimpler frimpler commented Mar 13, 2019

In our tests, the <capability> element in <hello> message sporadically contained an empty deviations parameter ("&deviations="). The issue could be reproduced by a test case (test_server_thread.c).
We see the root cause in the missing initialization of v in in nc_server_get_cpblts_version().

Please have a look,
Frank

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #140 into devel will increase coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #140      +/-   ##
==========================================
+ Coverage   37.86%   38.07%   +0.21%     
==========================================
  Files          23       23              
  Lines        9922     9927       +5     
  Branches     1947     1947              
==========================================
+ Hits         3757     3780      +23     
+ Misses       5233     5202      -31     
- Partials      932      945      +13
Impacted Files Coverage Δ
src/session.c 40.55% <ø> (+2.02%) ⬆️
tests/test_server_thread.c 94.07% <100%> (+0.08%) ⬆️
tests/test_fd_comm.c 94.06% <0%> (-0.46%) ⬇️
src/session_server_tls.c 28.24% <0%> (-0.11%) ⬇️
src/io.c 45.47% <0%> (+0.26%) ⬆️
src/session_client.c 24.93% <0%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4e6657...cb9274f. Read the comment docs.

@michalvasko
Copy link
Copy Markdown
Member

Hi,
that is clearly a bug, thanks for the fix and test.

Regards,
Michal

@michalvasko michalvasko merged commit 0829309 into CESNET:devel Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants