libnetconf2 CHANGE QNX compatibility#220
Merged
michalvasko merged 2 commits intoCESNET:develfrom Apr 20, 2020
Merged
Conversation
michalvasko
requested changes
Apr 15, 2020
Member
michalvasko
left a comment
michalvasko
left a comment
There was a problem hiding this comment.
Okay, except for that one detail I think the changes are nice and clean so they can safely be merged.
Member
|
Hi, Regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #217
Below is a summary of the compatibility issues this solves:
libloginfor QNX onlycrypt.h,shadow.hexists instead of relying on OS checksgetspnam_runder QNXgetpeereidfor QNX only. This is because-D_XOPEN_SOURCE=500in CMakeLists.txt caused conflict with-D_POSIX_C_SOURCE=200809Land using#define _XOPEN_SOURCE 500insession_server.ccaused a host of issues with pthread stuff.libpthreadis removed from CMAKE_REQUIRED_LIBRARIES as it cmake failed to link while looking forgetpeereid.libpthreadis replaced bylibcon QNX.Other than those issues, I don't have a BSD/MAC system to test this against, so restricted it to QNX to avoid causing regression issues.