build CHANGE remove safety check#223
Merged
michalvasko merged 1 commit intoCESNET:develfrom Apr 21, 2020
Merged
Conversation
Member
|
Okay, merging. Regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #217
Removing the check for
libcrypt. One reason is thatlibcryptis linked later on so any checking should be done there. Second reason is some platforms might implement this functionality in a different library (e.g., QNX withliblogin). Also, the check can be bypassed by setting-DLIBCRYPT.The failure will be clear enough to indicate to the user what went wrong during compilation. Opted not to use
find_libraryto look for the appropriate library, as couldn't get it to findliblogin.