io BUGFIX do not fail when there is data left to read#229
Merged
michalvasko merged 1 commit intoCESNET:develfrom May 15, 2020
Merged
io BUGFIX do not fail when there is data left to read#229michalvasko merged 1 commit intoCESNET:develfrom
michalvasko merged 1 commit intoCESNET:develfrom
Conversation
When using the UNIX transport and depending on the timing between the server and client, the client may read the final reply to the <close-session> rpc *after* the server has closed the socket. When that occurs, poll() returns POLLHUP in revents meaning the server closed the socket which causes the following error on the client: ERR: Session 1: communication channel unexpectedly closed. ERR: Session 1: failed to receive a reply to <close-session>. When POLLHUP is returned in revents, make sure POLLIN is not present as well (if it is, it means that there is some data left to be read in the socket buffer). Link: https://www.greenend.org.uk/rjk/tech/poll.html Signed-off-by: Robin Jarry <robin.jarry@6wind.com>
Member
|
Seems good to me and it makes sense, thanks, merging. Regards, |
Contributor
Author
|
Thanks Michal 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the UNIX transport and depending on the timing between the server and client, the client may read the final reply to the
<close-session>rpc after the server has closed the socket. When that occurs,poll()returnsPOLLHUPinreventsmeaning the server closed the socket which causes the following error on the client:When
POLLHUPis returned inrevents, make surePOLLINis not present as well (if it is, it means that there is some data left to be read in the socket buffer).See https://www.greenend.org.uk/rjk/tech/poll.html for more details.