Fix parsing for notification after leaf#70
Merged
michalvasko merged 1 commit intoCESNET:develfrom Aug 13, 2018
Merged
Conversation
This commit fixes parsing of notification messages for the case where the notification follows a leaf. Prior to this change, if the notification followed a leaf, the notification would be missed. In the `LYS_LEAF` case, `elem` would be advanced to `elem->next` (the notification), but the `for` loop condition to detect the notification would not be re-evaluated due to the `goto next_node` jump. By the time the loop condition was re-evaluated, `elem` would have been advanced to the notification's child. We've written integration tests that demonstrate the problem. This commit, together with a forthcoming commit to sysrepo, will allow those failing test cases to pass. (See [CI results], lines 7282-7284, or [test source code].) These test cases cover several different variations of notifications tied to data nodes. [CI results]: https://travis-ci.org/ADTRAN/netopeer2-integration-tests/builds/414144146#L7282 [test source code]: https://github.com/ADTRAN/netopeer2-integration-tests/blob/master/tests/test_notif.py#L229
michalvasko
approved these changes
Aug 13, 2018
Member
|
Hi, Regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes parsing of notification messages for the case where the notification follows a leaf. Prior to this change, if the notification followed a leaf, the notification would be missed. In the
LYS_LEAFcase,elemwould be advanced toelem->next(the notification), but theforloop condition to detect the notification would not be re-evaluated due to thegoto next_nodejump. By the time the loop condition was re-evaluated,elemwould have been advanced to the notification's child.We've written integration tests that demonstrate the problem. This commit, together with ADTRAN/sysrepo@acac046, will allow those failing test cases to pass. (See CI results, lines 7282-7284, or test source code.) These test cases cover several different variations of notifications tied to data nodes.