Skip to content

avoid repeated tzset() calls #2363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025
Merged

avoid repeated tzset() calls #2363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/tree_data_common.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1620,14 +1620,29 @@ ly_time_tz_offset(void)
return ly_time_tz_offset_at(time(NULL));
}

/**
* @brief Call tzset() if not already called by this process.
*/
static void
ly_tzset_once(void)
{
static int ly_tzset_called = 0;

if (ly_tzset_called) {
return;
}
tzset();
ly_tzset_called = 1;
}

LIBYANG_API_DEF int
ly_time_tz_offset_at(time_t time)
{
struct tm tm_local, tm_utc;
int result = 0;

/* init timezone */
tzset();
ly_tzset_once();

/* get local and UTC time */
localtime_r(&time, &tm_local);
Expand Down Expand Up @@ -1777,7 +1792,7 @@ ly_time_time2str(time_t time, const char *fractions_s, char **str)
LY_CHECK_ARG_RET(NULL, str, LY_EINVAL);

/* init timezone */
tzset();
ly_tzset_once();

/* convert */
if (!localtime_r(&time, &tm)) {
Expand Down