Skip to content

Conversation

@frimpler
Copy link
Contributor

Hi,
I have added 2 unit tests, which trigger in two different ways that the yang parser won't be able to resolve features of leafrefs, because they are part of an augment and the feature is part of the augmented tree. Both test cases address different branches in source code and have to be considered both for the possible solution.

In general, this is a problem of the parsing sequence (and might work the other way round). I have added a suggestion how to solve this problem. Please have a look at the solution.

Regards,
Frank

@michalvasko michalvasko self-assigned this Sep 20, 2017
@codecov-io
Copy link

codecov-io commented Sep 20, 2017

Codecov Report

Merging #361 into devel will decrease coverage by 0.02%.
The diff coverage is 55.56%.

@@            Coverage Diff             @@
##            devel     #361      +/-   ##
==========================================
- Coverage   73.84%   73.82%   -0.02%     
==========================================
  Files          28       28              
  Lines       34608    34626      +18     
  Branches     8815     8821       +6     
==========================================
+ Hits        25556    25562       +6     
- Misses       9052     9064      +12

@michalvasko
Copy link
Member

Hi,
thanks for the bug report and test case but I fixed the problem itself in a different manner, there was simply a problem with the order of things being resolved.

Regards,
Michal

@frimpler
Copy link
Contributor Author

Thanx, Michal
I expected/hoped that you will find a better place. In fact my "solution" was just a workaround which I really didn't like. I assume the test cases helped to verify the correctness of the implementation :-)

Regards,
Frank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants