Highlight active Journal/Changelog tab on CO detail pages (#15)

[Kani999]

Summary

Fixes #15. On Custom Object detail pages, clicking the Journal or Changelog tab loaded the right page but never highlighted the clicked tab as active. Disabling this plugin made the active marker work again — root cause was on our side.

• Upstream CustomObjectJournalView / CustomObjectChangeLogView (netbox_custom_objects/views.py) call render(..., {"tab": "journal"}) / {"tab": "changelog"} — the active-tab marker in context is a string. NetBox's {% model_view_tabs %} (utilities/templatetags/tabs.py:53) computes is_active = active_tab == tab where tab is a ViewTab object, so the comparison is always False and the active class is never emitted. Verified still present on netboxlabs-netbox-custom-objects 0.5.0 and 0.5.1 with NetBox 4.6.1.
• Render Journal/Changelog as hardcoded <li> blocks (string equality works) and introduce a new {% plugin_extra_tabs %} template tag that mirrors model_view_tabs but skips the journal/changelog actions — required because netbox/models/features.py:737-742 auto-registers ObjectJournalView/ObjectChangeLogView in registry['views'] for every ChangeLoggedModel subclass, including dynamic CO models, so without the filter we'd render duplicate inert tabs.
• Tab order is now Primary → combined/typed → Journal → Changelog. Incidentally this matches the natural ViewTab weight ordering (combined=2000, typed=2100, Journal=5000, Changelog=10000), so the layout stays stable if upstream later switches to tab=self.tab and we drop the hardcoding.

Files

• netbox_custom_objects_tab/templatetags/__init__.py (new, empty)
• netbox_custom_objects_tab/templatetags/custom_object_tab_tags.py (new — {% plugin_extra_tabs %} tag)
• netbox_custom_objects_tab/templates/netbox_custom_objects/customobject.html (load tag, replace model_view_tabs with hardcoded Journal/Changelog + plugin_extra_tabs)
• CLAUDE.md (gotcha documenting the string-vs-ViewTab issue)

Test plan

• Restart NetBox after deploying this branch (template tag registration happens in AppConfig.ready())
• Open any CO detail page → primary type-name tab has nav-link active
• Click Journal → URL becomes …/<pk>/journal/, Journal anchor has nav-link active, primary/Changelog do not
• Click Changelog → URL becomes …/<pk>/changelog/, Changelog anchor has nav-link active, primary/Journal do not
• On a CO that has linked custom objects: confirm combined/typed tabs appear between Primary and Journal, in weight order
• No duplicate Journal/Changelog entries in <ul class="nav nav-tabs"> (DevTools console: [...document.querySelectorAll('ul.nav.nav-tabs a.nav-link')].map(a => a.textContent.trim()) shows each label once)
• Regression check: open a stock dcim.device detail page, click Journal/Changelog → active state still works (our template override is scoped to netbox_custom_objects/customobject.html only)
• ruff check netbox_custom_objects_tab/ && ruff format --check netbox_custom_objects_tab/ clean

Upstream follow-up (not in this PR)

The cleaner fix lives in netbox-custom-objects itself — CustomObjectJournalView.get() / CustomObjectChangeLogView.get() should pass "tab": self.tab instead of the string literal. Worth filing as a one-line PR against netboxlabs/netbox-custom-objects; once merged, we can delete the hardcoded <li> blocks and the plugin_extra_tabs tag and go back to a single {% model_view_tabs object %}. Until then this workaround carries the weight.

---

Additional change folded into this PR: track netbox-custom-objects v0.5.1

After this branch opened, upstream netbox-custom-objects v0.5.1 shipped. Floor bumps folded in (commit 5428c13) since they share the same release artifact (2.4.1):

• PluginConfig.min_version: 4.5.0 → 4.5.2 (mirrors upstream's NetBox floor bump in netboxlabs/netbox-custom-objects#511 — keeps both gates consistent so a NetBox 4.5.0/4.5.1 host can't end up with our plugin loading while upstream refuses to start).
• Runtime gate in PluginConfig.ready(): >= 0.5.0 → >= 0.5.1 (message text only; the behavioural probe still keys off the 0.5.0 is_polymorphic schema sentinel, since no field added in 0.5.1 is a reliable runtime marker).
• README Requirements + 2.4.x Compatibility row updated.
• CHANGELOG: floor-bump entry folded under the existing [2.4.1] - 2026-05-25 block as ### Changed (same-day metadata refinement, no version bump).

No plugin code-logic changes were needed. Our query helpers (combined.py::_iter_linked_fields, typed.py::_build_q_for_field) already filter by instance.pk (int) rather than by model instance, so upstream's #508 rewrite of CustomObjectLink.left_page() from filter(**{field.name: target_obj}) to filter(**{f"{field.name}_id": target_obj.pk}) doesn't affect us. The M2M path_infos repair from #483 is applied inside CustomObjectType.get_model(), which we call per request — inherited for free.

Additional test plan items

• Clean startup on NetBox 4.5.2 / 4.6.x with netbox-custom-objects 0.5.1
• Negative test: pip install 'netbox-custom-objects==0.5.0' → startup aborts with ImproperlyConfigured pointing at >=0.5.1. Re-install 0.5.1 to restore.