CORE,RPC: Added removeAttributes for member,group and user#2002
Merged
stavamichal merged 1 commit intoCESNET:masterfrom Oct 15, 2018
Merged
CORE,RPC: Added removeAttributes for member,group and user#2002stavamichal merged 1 commit intoCESNET:masterfrom
stavamichal merged 1 commit intoCESNET:masterfrom
Conversation
- We were missing member,group and workWithUserAttributes in API. Since GUI sends same combination of params for setAttributes() and removeAttributes(), it failed to resolve proper method in RPC API, since this combination was not supported for removeAttributes(). - Now we use method with boolean param and use it in entry layer for both removeAttributes() methods (like we do for resource-group).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since GUI sends same combination of params for setAttributes()
and removeAttributes(), it failed to resolve proper method
in RPC API, since this combination was not supported for
removeAttributes().
for both removeAttributes() methods (like we do for resource-group).