feat(core): add PROXY role #3966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Johaney-s
commented
May 25, 2023
Johaney-s
commented
- to remove perunadmin role for proxy, new role is created
- it covers necessary method calls and attribute rights
Johaney-s
force-pushed
the
proxy_role
branch
3 times, most recently
from
1e32326 to
8e077a2
Compare
* to remove perunadmin role for proxy, new role is created * it covers necessary method calls and attribute rights
bodnara
approved these changes
Jun 5, 2023
Contributor
bodnara
left a comment
bodnara
left a comment
There was a problem hiding this comment.
Looks good. However I can't speak whether new role was added to all required methods, and correct rights were given to all attribute definitions.
|
🎉 This PR is included in version 26.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.