fix(core): fixed attributes parsing for sql group structure sync #3972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zations The current parsing does not include additional group attributes like "g:d:adName". I have used the previous implementation of the process except getting DB connection which is still taken from the DB pool.
zlamalp
approved these changes
Jun 1, 2023
Contributor
zlamalp
left a comment
zlamalp
left a comment
There was a problem hiding this comment.
I think that we don't have to re-introduce so much of the old code (e.g. for handling blobs), since we are using better implementation in querySource() already, but it should work. Since it passed the manual testing I'm ok with it to be a quickfix.
|
🎉 This PR is included in version 26.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current parsing does not include additional group attributes like
g:d:adName.I have used the previous implementation of the process except for getting the DB connection which is still taken from the DB pool.