fix(core): enforce mfa modul - correctly retrieve mfa categories #4066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bodnara
commented
Sep 1, 2023
bodnara
commented
- used full attribute name instead of friendly name
- case when mfa categories does not exist is handled
mattjoke
approved these changes
Sep 1, 2023
Contributor
mattjoke
left a comment
mattjoke
left a comment
There was a problem hiding this comment.
Apart from little nit-picks, it looks okay. Good job 👍
.../perun/core/impl/modules/attributes/urn_perun_user_attribute_def_def_mfaEnforceSettings.java
Outdated
Show resolved
Hide resolved
.../perun/core/impl/modules/attributes/urn_perun_user_attribute_def_def_mfaEnforceSettings.java
Outdated
Show resolved
Hide resolved
* used full attribute name instead of freindly name * case when mfa categories does not exist is handled
bodnara
force-pushed
the
fixMfaEnforceModule
branch
from
c911f34 to
dafdc82
Compare
HejdaJakub
approved these changes
Sep 4, 2023
|
🎉 This PR is included in version 29.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.