feat(core): allow resource managers to read subgroup managers #4084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xflord
reviewed
Sep 18, 2023
Contributor
xflord
left a comment
xflord
left a comment
There was a problem hiding this comment.
This should work, just make sure to manually test as well (some other policies might be used in the gui app).
Would be nice to include why this change was made in the commit message.
I just thought of a scenario where some group in the VO could be managed solely by VOADMINs, in which case the RESOURCEADMIN still does not know who to contact. Not sure how often this happens in production though. Also, this was not defined in the task, it's more just a question for @balcirakpeter
- Allowed RESOURCEADMIN, TRUSTEDFACILITYADMIN and RESOURCEOBSERVER to read GROUPADMIN and GROUPMEMBERSHIPMANAGER in the VO. - This way the resource managers know who to contact in the matter of membership in the assigned groups.
kofzera
force-pushed
the
allow_resource_manager_read_subgroup_managers
branch
from
9b8f3e2 to
ba1bb15
Compare
xflord
approved these changes
Sep 19, 2023
sarkapalkovicova
approved these changes
Sep 21, 2023
michalberky
approved these changes
Sep 21, 2023
|
🎉 This PR is included in version 30.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read GROUPADMIN and GROUPMEMBERSHIPMANAGER in the VO.
of membership in the assigned groups.