Fix tests not passing in test_pyi_gen.py#269
Merged
CEXT-Dan merged 10 commits intoCEXT-Dan:mainfrom Apr 14, 2025
Merged
Conversation
added 10 commits
April 14, 2025 18:23
…BoostPythonInstanceClassPyiGenerator[005]
Owner
|
Thank you! |
Owner
|
there's a lot of noise in the gen logs, not sure where this was introduced |
Contributor
Author
I'll look into that! |
CEXT-Dan
added a commit
that referenced
this pull request
May 31, 2025
Fix tests not passing in test_pyi_gen.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request:
TypeVarfrom the types that are added in the .pyi files, as it is not used and is systematically removed by rufftypingfollowing the isort conventionAxmodule right afterApin sequences where it was mispositioned