Skip to content

PMP: compare_meshes#5544

Merged
sloriot merged 29 commits intoCGAL:masterfrom
maxGimeno:PMP-compare_faces_from_meshes-maxGimeno
Jul 19, 2021
Merged

PMP: compare_meshes#5544
sloriot merged 29 commits intoCGAL:masterfrom
maxGimeno:PMP-compare_faces_from_meshes-maxGimeno

Conversation

@maxGimeno
Copy link
Contributor

@maxGimeno maxGimeno commented Mar 22, 2021 •
edited
Loading

Summary of Changes

Add a function in PMP that compares 2 meshes, and separate the faces that are only in the first, only in the second, and in both meshes.

Release Management

@maxGimeno maxGimeno added Not yet approved The feature or pull-request has not yet been approved. Small feature TODO Pkg::PMP labels Mar 22, 2021
@maxGimeno maxGimeno added this to the 5.4-beta milestone Mar 22, 2021
@maxGimeno maxGimeno self-assigned this Mar 22, 2021
@maxGimeno maxGimeno force-pushed the PMP-compare_faces_from_meshes-maxGimeno branch from 9bf0dd5 to 836a7b8 Compare March 22, 2021 13:14
sloriot
sloriot reviewed Mar 22, 2021
View reviewed changes
sloriot
sloriot reviewed Mar 23, 2021
View reviewed changes
MaelRL
MaelRL requested changes May 25, 2021
View reviewed changes
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/measure.h
Comment on lines +856 to +858
* @param common output iterator collecting the faces that are common to both meshes.
* @param m1_only output iterator collecting the faces that are only in `m1`
* @param m2_only output iterator collecting the faces that are only in `m2`
Copy link
Member

@MaelRL MaelRL May 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't top notch variable names

Copy link
Contributor Author

@maxGimeno maxGimeno May 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

faces_only_present_in_m1_output_iteratorwould be far too long to be a good variable name, IMHO

@maxGimeno maxGimeno force-pushed the PMP-compare_faces_from_meshes-maxGimeno branch from 95ba54e to c6c5405 Compare May 26, 2021 10:37
lrineau
lrineau reviewed May 26, 2021
View reviewed changes
@MaelRL MaelRL added the Not yet approved The feature or pull-request has not yet been approved. label Jun 7, 2021
@sloriot sloriot mentioned this pull request Jun 25, 2021
Merged
4 tasks
@MaelRL MaelRL added Accepted small feature and removed pre-approved For pre-approved small features. After 15 days the feature will be accepted. Not yet approved The feature or pull-request has not yet been approved. labels Jun 30, 2021
@sloriot
Copy link
Member

sloriot commented Jul 19, 2021

Successfully tested in 5.4-Ic-8

@sloriot sloriot merged commit 9b27f53 into CGAL:master Jul 19, 2021
@sloriot sloriot deleted the PMP-compare_faces_from_meshes-maxGimeno branch July 19, 2021 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sloriot sloriot sloriot left review comments

@afabri afabri afabri left review comments

@MaelRL MaelRL MaelRL requested changes

@lrineau lrineau lrineau left review comments

Assignees

@maxGimeno maxGimeno

Labels

Accepted small feature Merged_in_5.4-beta1 Merged_in_5.4 Pkg::PMP Small feature Tested

Projects

None yet

Milestone

5.4-beta

Development

Successfully merging this pull request may close these issues.

5 participants

@maxGimeno @sloriot @afabri @MaelRL @lrineau