Skip to content

Segment_2/Segment_3 midpoint()#5545

Merged
lrineau merged 2 commits intoCGAL:masterfrom
Dig-Doug:segment-midpoint
Jul 7, 2021
Merged

Segment_2/Segment_3 midpoint()#5545
lrineau merged 2 commits intoCGAL:masterfrom
Dig-Doug:segment-midpoint

Conversation

@Dig-Doug
Copy link
Contributor

@Dig-Doug Dig-Doug commented Mar 22, 2021

Summary of Changes

Adds a CGAL::midpoint() implementation for segments.

In the documentation: function and concept

Release Management

  • Affected package(s): Kernel_23
  • Issue(s) solved (if any): -
  • Feature/Small Feature (if any): n/a
  • License and copyright ownership: CLA signed

@MaelRL MaelRL added this to the 5.4-beta milestone Mar 25, 2021
@afabri
Copy link
Member

afabri commented Apr 22, 2021

Hello @Dig-Doug, I just made the code more complex, or call it more CGAL compliant. The free function has to call the functor which does the real work. We are in the lucky situation where the functor already existed.

@afabri
Copy link
Member

afabri commented Apr 22, 2021

/build:v0

@github-actions
Copy link

The documentation is built. It will be available, after a few minutes, here : https://cgal.github.io/5545/v0/Manual/index.html

@Dig-Doug
Copy link
Contributor Author

No problem, please let me know if you need anything else from me.

@lrineau lrineau added the CLA/CAA OK The contributor has signed a CLA or a CAA suitable for this contribution label Apr 26, 2021
@lrineau lrineau added the rm: not for next release Indicate to the release team that a PR should not be merged before the next release branch is forked label Jun 7, 2021
@maxGimeno
Copy link
Contributor

@lrineau lrineau removed the rm: not for next release Indicate to the release team that a PR should not be merged before the next release branch is forked label Jul 7, 2021
@lrineau lrineau merged commit 0f906ae into CGAL:master Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA/CAA OK The contributor has signed a CLA or a CAA suitable for this contribution Enhancement Merged_in_5.4-beta1 Merged_in_5.4 Pkg::Kernel_23 Tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants