Skip to content

[Feature] Barycentric Coordinates 2 Revision#5738

Merged
sloriot merged 72 commits intoCGAL:masterfrom
danston:Barycentric_coordinates_2-danston
Aug 25, 2021
Merged

[Feature] Barycentric Coordinates 2 Revision#5738
sloriot merged 72 commits intoCGAL:masterfrom
danston:Barycentric_coordinates_2-danston

Conversation

@danston
Copy link
Contributor

@danston danston commented May 28, 2021

This PR proposes a new updated and revised version of the Barycentric_coordinates_2 package. Many things have been changed including the API that became much more flexible + the new harmonic coordinates are added. The docs and tests have been extended and improved, too.

Release Management

This PR depends on #5736 and #5737.

@danston danston added Feature Not yet approved The feature or pull-request has not yet been approved. labels May 31, 2021
@danston danston linked an issue Jun 3, 2021 that may be closed by this pull request
@MaelRL MaelRL added this to the 5.4-beta milestone Jun 5, 2021
@danston
Copy link
Contributor Author

danston commented Aug 12, 2021

@maxGimeno I think this PR can be tested now. Thanks!

@sloriot
Copy link
Member

sloriot commented Aug 13, 2021

There are warnings in the testsuite. I already fixed the case issue in the cmake script (did it in the doc yesterday but did not think about cmake :( )

@danston
Copy link
Contributor Author

danston commented Aug 13, 2021

Actually, this error is super weird. I already fixed that many times and after pushing it gets back. Maybe it is my editor. I have no idea why this happens((

@sloriot
Copy link
Member

sloriot commented Aug 18, 2021

@danston
Copy link
Contributor Author

danston commented Aug 18, 2021

@sloriot In the last test suite lc-31, there are no errors, and the ones, you refer, do not seem to be caused by the BC package imho. Are they?

@sloriot
Copy link
Member

sloriot commented Aug 18, 2021

Ic-31 = master

@danston
Copy link
Contributor Author

danston commented Aug 19, 2021

@sloriot I think now it can be tested again. Thanks!

@sloriot
Copy link
Member

sloriot commented Aug 25, 2021

Successfully tested in CGAL-5.4-Ic-36

@sloriot sloriot merged commit 7e21277 into CGAL:master Aug 25, 2021
@danston danston deleted the Barycentric_coordinates_2-danston branch September 22, 2021 09:09
@sloriot sloriot added the gsoc label Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dead link in Barycentric_coordinates_2 Barycentric Coordinates: Cleanup required

6 participants