[Feature] Barycentric Coordinates 2 Revision#5738
Merged
sloriot merged 72 commits intoCGAL:masterfrom Aug 25, 2021
Merged
Conversation
…es, fixed several warnings
…erminant_2-danston' into Barycentric_coordinates_2-danston
…o Barycentric_coordinates_2-danston
…erminant_2-danston' into Barycentric_coordinates_2-danston
…o Barycentric_coordinates_2-danston
…o Barycentric_coordinates_2-danston
…o Barycentric_coordinates_2-danston
Contributor
Author
|
@maxGimeno I think this PR can be tested now. Thanks! |
Member
|
There are warnings in the testsuite. I already fixed the case issue in the cmake script (did it in the doc yesterday but did not think about cmake :( ) |
Contributor
Author
|
Actually, this error is super weird. I already fixed that many times and after pushing it gets back. Maybe it is my editor. I have no idea why this happens(( |
Contributor
Author
|
@sloriot In the last test suite lc-31, there are no errors, and the ones, you refer, do not seem to be caused by the BC package imho. Are they? |
Member
|
Ic-31 = master |
Contributor
Author
|
@sloriot I think now it can be tested again. Thanks! |
Member
|
Successfully tested in CGAL-5.4-Ic-36 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes a new updated and revised version of the
Barycentric_coordinates_2package. Many things have been changed including the API that became much more flexible + the new harmonic coordinates are added. The docs and tests have been extended and improved, too.Release Management
This PR depends on #5736 and #5737.
Barycentric_coordinates_2